Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 2704933002: Guard against NPE caused by invalid code (issue 28829) (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-19 18:14:12 UTC) #2
devoncarew
lgtm lgtm, thanks!
3 years, 10 months ago (2017-02-19 21:47:37 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-20 17:29:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bb9fb5f966d066e0c219f525c82521a73d18e02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698