Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: media/cast/rtcp/rtcp_receiver.cc

Issue 270493003: Cast: Deduplicate event types in cast library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/rtcp/rtcp_defines.cc ('k') | media/cast/rtcp/rtcp_receiver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/rtcp/rtcp_receiver.cc
diff --git a/media/cast/rtcp/rtcp_receiver.cc b/media/cast/rtcp/rtcp_receiver.cc
index 9345d5850ae2377698ff4deb2b8cbe761dcb80ad..f5100b963cb2ef6874c1117e2ffa0825deab9c42 100644
--- a/media/cast/rtcp/rtcp_receiver.cc
+++ b/media/cast/rtcp/rtcp_receiver.cc
@@ -10,13 +10,6 @@
namespace {
-bool IsRtcpPacketEvent(media::cast::CastLoggingEvent event_type) {
- return event_type == media::cast::kAudioPacketReceived ||
- event_type == media::cast::kVideoPacketReceived ||
- event_type == media::cast::kDuplicateAudioPacketReceived ||
- event_type == media::cast::kDuplicateVideoPacketReceived;
-}
-
media::cast::transport::RtcpSenderFrameStatus
TranslateToFrameStatusFromWireFormat(uint8 status) {
switch (status) {
@@ -479,7 +472,7 @@ void RtcpReceiver::HandleApplicationSpecificCastReceiverEventLog(
const uint8 event = rtcp_field.cast_receiver_log.event;
const CastLoggingEvent event_type = TranslateToLogEventFromWireFormat(event);
- uint16 packet_id = IsRtcpPacketEvent(event_type) ?
+ uint16 packet_id = event_type == PACKET_RECEIVED ?
rtcp_field.cast_receiver_log.delay_delta_or_packet_id.packet_id : 0;
const base::TimeTicks event_timestamp =
base::TimeTicks() +
« no previous file with comments | « media/cast/rtcp/rtcp_defines.cc ('k') | media/cast/rtcp/rtcp_receiver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698