Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: media/cast/rtcp/rtcp_receiver.cc

Issue 270493003: Cast: Deduplicate event types in cast library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/rtcp/rtcp_defines.cc ('k') | media/cast/rtcp/rtcp_receiver_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/rtcp/rtcp_receiver.h" 5 #include "media/cast/rtcp/rtcp_receiver.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "media/cast/rtcp/rtcp_utility.h" 8 #include "media/cast/rtcp/rtcp_utility.h"
9 #include "media/cast/transport/cast_transport_defines.h" 9 #include "media/cast/transport/cast_transport_defines.h"
10 10
11 namespace { 11 namespace {
12 12
13 bool IsRtcpPacketEvent(media::cast::CastLoggingEvent event_type) {
14 return event_type == media::cast::kAudioPacketReceived ||
15 event_type == media::cast::kVideoPacketReceived ||
16 event_type == media::cast::kDuplicateAudioPacketReceived ||
17 event_type == media::cast::kDuplicateVideoPacketReceived;
18 }
19
20 media::cast::transport::RtcpSenderFrameStatus 13 media::cast::transport::RtcpSenderFrameStatus
21 TranslateToFrameStatusFromWireFormat(uint8 status) { 14 TranslateToFrameStatusFromWireFormat(uint8 status) {
22 switch (status) { 15 switch (status) {
23 case 0: 16 case 0:
24 return media::cast::transport::kRtcpSenderFrameStatusUnknown; 17 return media::cast::transport::kRtcpSenderFrameStatusUnknown;
25 case 1: 18 case 1:
26 return media::cast::transport::kRtcpSenderFrameStatusDroppedByEncoder; 19 return media::cast::transport::kRtcpSenderFrameStatusDroppedByEncoder;
27 case 2: 20 case 2:
28 return media::cast::transport::kRtcpSenderFrameStatusDroppedByFlowControl; 21 return media::cast::transport::kRtcpSenderFrameStatusDroppedByFlowControl;
29 case 3: 22 case 3:
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 } 465 }
473 466
474 void RtcpReceiver::HandleApplicationSpecificCastReceiverEventLog( 467 void RtcpReceiver::HandleApplicationSpecificCastReceiverEventLog(
475 uint32 frame_rtp_timestamp, 468 uint32 frame_rtp_timestamp,
476 RtcpParser* rtcp_parser, 469 RtcpParser* rtcp_parser,
477 RtcpReceiverEventLogMessages* event_log_messages) { 470 RtcpReceiverEventLogMessages* event_log_messages) {
478 const RtcpField& rtcp_field = rtcp_parser->Field(); 471 const RtcpField& rtcp_field = rtcp_parser->Field();
479 472
480 const uint8 event = rtcp_field.cast_receiver_log.event; 473 const uint8 event = rtcp_field.cast_receiver_log.event;
481 const CastLoggingEvent event_type = TranslateToLogEventFromWireFormat(event); 474 const CastLoggingEvent event_type = TranslateToLogEventFromWireFormat(event);
482 uint16 packet_id = IsRtcpPacketEvent(event_type) ? 475 uint16 packet_id = event_type == PACKET_RECEIVED ?
483 rtcp_field.cast_receiver_log.delay_delta_or_packet_id.packet_id : 0; 476 rtcp_field.cast_receiver_log.delay_delta_or_packet_id.packet_id : 0;
484 const base::TimeTicks event_timestamp = 477 const base::TimeTicks event_timestamp =
485 base::TimeTicks() + 478 base::TimeTicks() +
486 base::TimeDelta::FromMilliseconds( 479 base::TimeDelta::FromMilliseconds(
487 rtcp_field.cast_receiver_log.event_timestamp_base + 480 rtcp_field.cast_receiver_log.event_timestamp_base +
488 rtcp_field.cast_receiver_log.event_timestamp_delta); 481 rtcp_field.cast_receiver_log.event_timestamp_delta);
489 482
490 // The following code checks to see if we have already seen this event. 483 // The following code checks to see if we have already seen this event.
491 // The algorithm works by maintaining a sliding window of events. We have 484 // The algorithm works by maintaining a sliding window of events. We have
492 // a queue and a set of events. We enqueue every new event and insert it 485 // a queue and a set of events. We enqueue every new event and insert it
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 void RtcpReceiver::HandleFIRItem(const RtcpField* rtcp_field) { 608 void RtcpReceiver::HandleFIRItem(const RtcpField* rtcp_field) {
616 // Is it our sender that is requested to generate a new keyframe. 609 // Is it our sender that is requested to generate a new keyframe.
617 if (ssrc_ != rtcp_field->fir_item.ssrc) 610 if (ssrc_ != rtcp_field->fir_item.ssrc)
618 return; 611 return;
619 612
620 VLOG(2) << "Cast RTCP received FIR on our SSRC " << ssrc_; 613 VLOG(2) << "Cast RTCP received FIR on our SSRC " << ssrc_;
621 } 614 }
622 615
623 } // namespace cast 616 } // namespace cast
624 } // namespace media 617 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/rtcp/rtcp_defines.cc ('k') | media/cast/rtcp/rtcp_receiver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698