Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 270483003: Oilpan: Prepare to move HTMLFormElement, HTMLFormElement::PastNamesMap, FormKeyGenerator, and FormS… (Closed)

Created:
6 years, 7 months ago by tkent
Modified:
6 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+loader_chromium.org, Nate Chapin
Visibility:
Public.

Description

Oilpan: Prepare to move HTMLFormElement, HTMLFormElement::PastNamesMap, FormKeyGenerator, and FormState to Oilpan heap. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173748

Patch Set 1 #

Total comments: 3

Patch Set 2 : FIXME: Oilpan: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -39 lines) Patch
M Source/core/html/HTMLFormElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FormController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FormController.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/core/html/forms/InputTypeView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputTypeView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 3 chunks +10 lines, -4 lines 0 comments Download
M Source/core/loader/FormState.h View 3 chunks +6 lines, -4 lines 0 comments Download
M Source/core/loader/FormState.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M Source/core/loader/FormSubmission.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/FormSubmission.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoadRequest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tkent
6 years, 7 months ago (2014-05-09 09:04:46 UTC) #1
haraken
LGTM https://codereview.chromium.org/270483003/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp File Source/core/html/parser/HTMLConstructionSite.cpp (right): https://codereview.chromium.org/270483003/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp#newcode744 Source/core/html/parser/HTMLConstructionSite.cpp:744: // FIXME: HTMLElementFactory::createHTMLElement should return a raw pointer. ...
6 years, 7 months ago (2014-05-09 09:27:34 UTC) #2
keishi
lgtm
6 years, 7 months ago (2014-05-09 09:31:06 UTC) #3
zerny-chromium
lgtm https://codereview.chromium.org/270483003/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp File Source/core/html/parser/HTMLConstructionSite.cpp (right): https://codereview.chromium.org/270483003/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp#newcode744 Source/core/html/parser/HTMLConstructionSite.cpp:744: // FIXME: HTMLElementFactory::createHTMLElement should return a raw pointer. ...
6 years, 7 months ago (2014-05-09 09:37:58 UTC) #4
tkent
https://codereview.chromium.org/270483003/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp File Source/core/html/parser/HTMLConstructionSite.cpp (right): https://codereview.chromium.org/270483003/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp#newcode744 Source/core/html/parser/HTMLConstructionSite.cpp:744: // FIXME: HTMLElementFactory::createHTMLElement should return a raw pointer. On ...
6 years, 7 months ago (2014-05-09 09:46:30 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 7 months ago (2014-05-09 09:46:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/270483003/20001
6 years, 7 months ago (2014-05-09 09:48:31 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 10:28:01 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 11:52:19 UTC) #9
Message was sent while issue was closed. 
Change committed as 173748

Powered by Google App Engine
This is Rietveld 408576698