Move PlatformScreen, PlatformScreenChromium, and Widget to Source/platform

Move PlatformScreen, PlatformScreenChromium, and Widget to Source/platform

BUG=297477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159793

[atreat, 2013-10-11 18:24:02]

This is the fruit of issue 26936002

[eseidel, 2013-10-11 18:28:55]

lgtm

Widget has no place in the OOPI world.  screen information will be on the other
side of the embedder, so if anything platform/ will expose a cached version
which it gets from web/platform.

Thanks for helping with the move efforts.

https://codereview.chromium.org/27048004/diff/1/Source/platform/PlatformScreen.h
File Source/platform/PlatformScreen.h (right):

https://codereview.chromium.org/27048004/diff/1/Source/platform/PlatformScree...
Source/platform/PlatformScreen.h:42: PLATFORM_EXPORT int screenDepth(Widget*);
We should just change this not to take a Widget, but rather some other pointer
which can be accessed from the Frame.

https://codereview.chromium.org/27048004/diff/1/Source/platform/Widget.h
File Source/platform/Widget.h (right):

https://codereview.chromium.org/27048004/diff/1/Source/platform/Widget.h#newc...
Source/platform/Widget.h:51: class PLATFORM_EXPORT Widget : public
RefCounted<Widget> {
I'm not sure this buys us much to move this to platform.  But it's OK.  We
certainly don't want this long-term part of platform/

[commit-bot: I haz the power, 2013-10-11 18:29:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/27048004/1

[commit-bot: I haz the power, 2013-10-11 18:29:28]

Failed to apply patch for Source/platform/Widget.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/platform/Widget.h
  Copied Source/core/platform/Widget.h -> Source/platform/Widget.h
  patching file Source/platform/Widget.h
  Hunk #2 FAILED at 48.
  1 out of 4 hunks FAILED -- saving rejects to file Source/platform/Widget.h.rej

Patch:   NR  Source/core/platform/Widget.h->Source/platform/Widget.h
Index: Source/platform/Widget.h
diff --git a/Source/core/platform/Widget.h b/Source/platform/Widget.h
similarity index 95%
rename from Source/core/platform/Widget.h
rename to Source/platform/Widget.h
index
fc4f0c19ca8bdf91a2d21f31da16dfeb8345a464..2a8acca8c9641e3917968f2d2ace8d4e731148c6
100644
--- a/Source/core/platform/Widget.h
+++ b/Source/platform/Widget.h
@@ -28,6 +28,7 @@
 #ifndef Widget_h
 #define Widget_h
 
+#include "platform/PlatformExport.h"
 #include "platform/geometry/IntRect.h"
 #include "wtf/Forward.h"
 #include "wtf/RefCounted.h"
@@ -47,7 +48,7 @@ class HostWindow;
 // Widgets are connected in a hierarchy, with the restriction that plugins and
 // scrollbars are always leaves of the tree. Only ScrollViews can have children
 // (and therefore the Widget class has no concept of children).
-class Widget : public RefCounted<Widget> {
+class PLATFORM_EXPORT Widget : public RefCounted<Widget> {
 public:
     Widget();
     virtual ~Widget();
@@ -103,9 +104,9 @@ public:
     IntPoint convertToRootView(const IntPoint&) const;
     IntPoint convertFromRootView(const IntPoint&) const;
 
-    // It is important for cross-platform code to realize that Mac has flipped
coordinates.  Therefore any code
+    // It is important for cross-platform code to realize that Mac has flipped
coordinates. Therefore any code
     // that tries to convert the location of a rect using the point-based
convertFromContainingWindow will end
-    // up with an inaccurate rect.  Always make sure to use the rect-based
convertFromContainingWindow method
+    // up with an inaccurate rect. Always make sure to use the rect-based
convertFromContainingWindow method
     // when converting window rects.
     IntRect convertToContainingWindow(const IntRect&) const;
     IntRect convertFromContainingWindow(const IntRect&) const;
@@ -116,7 +117,7 @@ public:
     virtual void frameRectsChanged() { }
 
     // Notifies this widget that other widgets on the page have been
repositioned.
-    virtual void widgetPositionsUpdated() {}
+    virtual void widgetPositionsUpdated() { }
 
     // Notifies this widget that its clip rect changed.
     virtual void clipRectChanged() { }

[commit-bot: I haz the power, 2013-10-12 00:39:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/27048004/1

[commit-bot: I haz the power, 2013-10-12 09:47:26]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-12 11:34:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/27048004/1

[commit-bot: I haz the power, 2013-10-12 13:01:14]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-16 12:42:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/27048004/1

[commit-bot: I haz the power, 2013-10-16 12:42:12]

Failed to apply patch for Source/platform/Widget.cpp:
File exist but was about to be overwriten
Patch:   NR  Source/core/platform/Widget.cpp->Source/platform/Widget.cpp
Index: Source/platform/Widget.cpp
diff --git a/Source/core/platform/Widget.cpp b/Source/platform/Widget.cpp
similarity index 99%
rename from Source/core/platform/Widget.cpp
rename to Source/platform/Widget.cpp
index
1cd6b4d6b693cca3175a2edb2ae8d009320acab7..8d8f28c1b662810a329d76b6aeeb51adb30bff6b
100644
--- a/Source/core/platform/Widget.cpp
+++ b/Source/platform/Widget.cpp
@@ -25,7 +25,7 @@
  */
 
 #include "config.h"
-#include "core/platform/Widget.h"
+#include "platform/Widget.h"
 
 #include "platform/HostWindow.h"
 #include "platform/geometry/IntRect.h"

[commit-bot: I haz the power, 2013-10-16 13:29:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/27048004/6001

[commit-bot: I haz the power, 2013-10-16 18:03:03]

Change committed as 159793