Issue 27048: Fix a crash when dns prefetching was being shut down without being started....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27048: Fix a crash when dns prefetching was being shut down without being started.... (Closed)

Created:
11 years, 10 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, darin (slow to review), nsylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix a crash when dns prefetching was being shut down without being started. This happened when BrowserMain exited before the point when we initialized dns prefetching, but after BrowserProcessImpl was created. We do shutdown of dns prefetching in ~BrowserProcessImpl. Example way to trigger the crash: open a saved HTML page while Chrome is already running. Change ShutdownDnsPrefetch to EnsureDnsPrefetchingShutdown which does nothing if dns prefetching has not been initialized. This is the simplest way to prevent the crash and we don't want to complicate the startup sequence even more. BUG=7900

Patch Set 1 #

Patch Set 2 : drop the ui test #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	chrome/browser/browser_process_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/dns_global.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/net/dns_global.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please review: nsylvain: to push it quickly darin: TBR, main review

11 years, 10 months ago (2009-02-23 19:18:50 UTC) #1

LGTM

Expand Messages | Collapse Messages