pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart - Issue 2704753002: Implement line and column numbers.

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

Issue 2704753002: Implement line and column numbers. (Closed)

Patch Set: Undo whitespace change. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« pkg/front_end/lib/src/fasta/compiler_context.dart ('K') | « pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

index eb5c3123869a712622f3bd59ba62ab922ac805bd..9516bf2cc42bb3c6314aeda66c044dada6ee4bc5 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

@@ -15,6 +15,9 @@ import 'package:kernel/ast.dart' show

import 'package:kernel/type_algebra.dart' show

substitute;

+import '../messages.dart' show

+ warning;

import 'kernel_builder.dart' show

FormalParameterBuilder,

FunctionTypeAliasBuilder,

@@ -45,7 +48,7 @@ class KernelFunctionTypeAliasBuilder

if (thisType == const InvalidType()) {

thisType = const DynamicType();

// TODO(ahe): Build an error somehow.

- print("${parent.uri}: Cyclic typedef: $name.");

+ warning(parent.uri, -1, "Cyclic typedef: '$name'.");

karlklose 2017/02/20 08:06:19 Not sure there should be a period at the end of th

ahe 2017/02/20 08:47:02 Why not? Grammatically, I think it should be: "Cy

karlklose 2017/02/20 08:52:35 This is not about the placement of '.' in combinat

ahe 2017/02/20 09:05:49 That's a good point, please don't hesitate to comp

}

return thisType;

}