Chromium Code Reviews| Index: pkg/front_end/lib/src/fasta/builder/builder.dart |
| diff --git a/pkg/front_end/lib/src/fasta/builder/builder.dart b/pkg/front_end/lib/src/fasta/builder/builder.dart |
| index 322179aaf14cc768cd3f897b97539b7ac11c4ee4..f1ed1b4de366c1815f9e5e430c838af6cdca1c26 100644 |
| --- a/pkg/front_end/lib/src/fasta/builder/builder.dart |
| +++ b/pkg/front_end/lib/src/fasta/builder/builder.dart |
| @@ -7,6 +7,9 @@ library fasta.builder; |
| import '../errors.dart' show |
| internalError; |
| +import '../messages.dart' show |
| + nit; |
| + |
| export 'class_builder.dart' show |
| ClassBuilder; |
| @@ -127,16 +130,17 @@ abstract class Builder { |
| preferred = other; |
| hidden = this; |
| } else { |
| - print("${library.uri}: Note: '$name' is imported from both " |
| + nit(library.fileUri, -1, "'$name' is imported from both " |
|
karlklose
2017/02/20 08:06:19
Consider defining a constant (like NO_COLUMN_INFOR
ahe
2017/02/20 08:47:02
Normally, I do prefer naming constants, but it fee
|
| "'${getUri(this)}' and '${getUri(other)}'."); |
| return library.buildAmbiguousBuilder(name, this, other, charOffset); |
| } |
| if (isLocal) { |
| - print("${library.uri}: Note: local definition of '$name' hides imported " |
| + nit(library.fileUri, -1, "Local definition of '$name' hides imported " |
| "version from '${getUri(other)}'."); |
| } else { |
| - print("${library.uri}: import of '$name' (from '${getUri(preferred)}') " |
| - "hides imported version from '${getUri(hidden)}'."); |
| + nit(library.fileUri, -1, "Import of '$name' " |
| + "(from '${getUri(preferred)}') hides imported version from " |
| + "'${getUri(hidden)}'."); |
| } |
| return preferred; |
| } |