Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: pkg/front_end/lib/src/fasta/source/source_library_builder.dart

Issue 2704753002: Implement line and column numbers. (Closed)
Patch Set: Change message. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/source_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/source_library_builder.dart b/pkg/front_end/lib/src/fasta/source/source_library_builder.dart
index 42464db93402cfd0ed0d16cf3bba72919ef47e94..e3e41b04cf8932be78dbcca437dafe0809bf5da0 100644
--- a/pkg/front_end/lib/src/fasta/source/source_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/source_library_builder.dart
@@ -14,6 +14,9 @@ import '../combinator.dart' show
import '../errors.dart' show
internalError;
+import '../messages.dart' show
+ warning;
+
import '../import.dart' show
Import;
@@ -302,14 +305,14 @@ abstract class SourceLibraryBuilder<T extends TypeBuilder, R>
void includePart(SourceLibraryBuilder<T, R> part) {
if (name != null) {
if (part.partOf == null) {
- print("${part.uri} has no 'part of' declaration but is used as a part "
- "by ${name} ($uri)");
+ warning(part.fileUri, -1, "Has no 'part of' declaration but is used as "
+ "a part by ${name} ($uri).");
parts.remove(part);
return;
}
if (part.partOf != name) {
- print("${part.uri} is part of '${part.partOf}' but is used as a part "
- "by '${name}' ($uri)");
+ warning(part.fileUri, -1, "Is part of '${part.partOf}' but is used as "
+ "a part by '${name}' ($uri).");
parts.remove(part);
return;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/source/outline_builder.dart ('k') | pkg/front_end/lib/src/fasta/source/source_loader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698