pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart - Issue 2704753002: Implement line and column numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

Issue 2704753002: Implement line and column numbers. (Closed)

Patch Set: Change message. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

index eb5c3123869a712622f3bd59ba62ab922ac805bd..8becf29506656464d6b9bd41002f9b1e176e6c55 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

@@ -15,6 +15,9 @@ import 'package:kernel/ast.dart' show

import 'package:kernel/type_algebra.dart' show

substitute;

+import '../messages.dart' show

+ warning;

import 'kernel_builder.dart' show

FormalParameterBuilder,

FunctionTypeAliasBuilder,

@@ -45,7 +48,8 @@ class KernelFunctionTypeAliasBuilder

if (thisType == const InvalidType()) {

thisType = const DynamicType();

// TODO(ahe): Build an error somehow.

- print("${parent.uri}: Cyclic typedef: $name.");

+ warning(parent.uri, -1,

+ "The typedef '$name' has a reference to itself.");

}

return thisType;

}