Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: pkg/front_end/lib/src/fasta/builder/builder.dart

Issue 2704753002: Implement line and column numbers. (Closed)
Patch Set: Change message. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/builder.dart b/pkg/front_end/lib/src/fasta/builder/builder.dart
index 322179aaf14cc768cd3f897b97539b7ac11c4ee4..f1ed1b4de366c1815f9e5e430c838af6cdca1c26 100644
--- a/pkg/front_end/lib/src/fasta/builder/builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/builder.dart
@@ -7,6 +7,9 @@ library fasta.builder;
import '../errors.dart' show
internalError;
+import '../messages.dart' show
+ nit;
+
export 'class_builder.dart' show
ClassBuilder;
@@ -127,16 +130,17 @@ abstract class Builder {
preferred = other;
hidden = this;
} else {
- print("${library.uri}: Note: '$name' is imported from both "
+ nit(library.fileUri, -1, "'$name' is imported from both "
"'${getUri(this)}' and '${getUri(other)}'.");
return library.buildAmbiguousBuilder(name, this, other, charOffset);
}
if (isLocal) {
- print("${library.uri}: Note: local definition of '$name' hides imported "
+ nit(library.fileUri, -1, "Local definition of '$name' hides imported "
"version from '${getUri(other)}'.");
} else {
- print("${library.uri}: import of '$name' (from '${getUri(preferred)}') "
- "hides imported version from '${getUri(hidden)}'.");
+ nit(library.fileUri, -1, "Import of '$name' "
+ "(from '${getUri(preferred)}') hides imported version from "
+ "'${getUri(hidden)}'.");
}
return preferred;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/bin/run.dart ('k') | pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698