src/opts/SkColor_opts_SSE2.h - Issue 270473003: Make gMask_00FF00FF a constant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/SkColor_opts_SSE2.h

Issue 270473003: Make gMask_00FF00FF a constant (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: const mask no-static Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/opts/SkColor_opts_SSE2.h

diff --git a/src/opts/SkColor_opts_SSE2.h b/src/opts/SkColor_opts_SSE2.h

index b06fe1a76fd585f88c01eb51b07c98e8d6d79c1a..7e61d526b3bf4427462b59e407187d32fb52bcd6 100644

--- a/src/opts/SkColor_opts_SSE2.h

+++ b/src/opts/SkColor_opts_SSE2.h

@@ -42,7 +42,7 @@ static inline __m128i SkAlphaMulAlpha_SSE2(const __m128i& a,

// Portable version SkAlphaMulQ is in SkColorPriv.h.

static inline __m128i SkAlphaMulQ_SSE2(const __m128i& c, const __m128i& scale) {

- __m128i mask = _mm_set1_epi32(gMask_00FF00FF);

+ __m128i mask = _mm_set1_epi32(0xFF00FF);

__m128i s = _mm_or_si128(_mm_slli_epi32(scale, 16), scale);

// uint32_t rb = ((c & mask) * scale) >> 8

« no previous file with comments | « src/core/SkBlitter.cpp ('k') | no next file » | no next file with comments »