Make gMask_00FF00FF a constant

include/core/SkMath.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkMath_DEFINED
 #define SkMath_DEFINED
 
 #include "SkTypes.h"
 
+///////////////////////////////////////////////////////////////////////////////
+
+enum { kMask_00FF00FF = 0xFF00FF };

[reed1, 2014/05/12 14:48:07]

I think we should just use 0xFF00FF where the sites need it, rather than have an
enum for this.

[pasko, 2014/05/12 15:06:19]

I agree. Done. Also removed one commented-out leftover gMask_00FF00FF.

+
+///////////////////////////////////////////////////////////////////////////////
+
 // 64bit -> 32bit utilities
 
 /**
  *  Return true iff the 64bit value can exactly be represented in signed 32bits
  */
 static inline bool sk_64_isS32(int64_t value) {
     return (int32_t)value == value;
 }
 
 /**
@@ skipping 195 matching lines @@
     *div = static_cast<Out>(d);
     *mod = static_cast<Out>(numer-d*denom);
 #else
     // On x86 this will just be a single idiv.
     *div = static_cast<Out>(numer/denom);
     *mod = static_cast<Out>(numer%denom);
 #endif  // SK_CPU_ARM
 }
 
 #endif