Precache tracking database

chrome/browser/history/most_visited_urls_provider.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[bengr, 2013/10/23 19:03:36]

2012 -> 2013. Remove the '(c)' too.

[sclittle, 2013/10/24 22:11:38]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/history/most_visited_urls_provider.h"
+
+#include "base/bind.h"
+#include "chrome/browser/history/top_sites.h"
+
+namespace history {
+
+MostVisitedURLsProvider::MostVisitedURLsProvider(TopSites* top_sites)

[bengr, 2013/10/23 19:03:36]

Can this be a const reference?

[sclittle, 2013/10/24 22:11:38]

Unfortunately, no. We need a non-const TopSites in order to call
top_sites->GetMostVisitedURLs, which is a non-const method.

+    : top_sites_(top_sites) {}
+MostVisitedURLsProvider::~MostVisitedURLsProvider() {}
+
+void MostVisitedURLsProvider::GetInterestingURLs(
+    const base::Callback<void(const std::list<GURL>&)>& callback) {
+  top_sites_->GetMostVisitedURLs(
+      base::Bind(&MostVisitedURLsProvider::OnMostVisitedURLsReceived,
+                 AsWeakPtr(), callback));
+}
+
+void MostVisitedURLsProvider::OnMostVisitedURLsReceived(
+    base::Callback<void(const std::list<GURL>&)> callback,

[bengr, 2013/10/23 19:03:36]

typedef this in the interface.

[sclittle, 2013/10/24 22:11:38]

Done.

+    const MostVisitedURLList& most_visited_urls) {
+  std::list<GURL> urls;
+  for (MostVisitedURLList::const_iterator it = most_visited_urls.begin();
+       it != most_visited_urls.end(); ++it) {
+    urls.push_back(it->url);
+  }
+  callback.Run(urls);
+}
+
+}  // namespace history