tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 2b5feef3ad36f2e24773d632b1a58c391df51af9..d5ed48a3d112940bc1663be512a81db53f18b13a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -13466,6 +13466,56 @@ other types of suffix sets.
   </summary>
 </histogram>
 
+<histogram name="Precache.DailyDownloadedNonPrecacheKB" units="KB">
+  <summary>
+    The daily number of kilobytes that were downloaded over any network for

[Alexei Svitkine (slow), 2013/11/11 20:04:11]

Clarify what "daily" means in the description. When is it actually logged? (e.g.
when is the check whether this should be logged performed - and does it cover
multiple sessions).

[sclittle, 2013/11/19 04:03:41]

Done.

+    HTTP/HTTPS fetches that were not motivated by precaching.
+  </summary>
+</histogram>
+
+<histogram name="Precache.DailyDownloadedNonPrecacheKB.Cellular" units="KB">

[Alexei Svitkine (slow), 2013/11/11 20:04:11]

You can make a new fieldtrial entry to handle all the ".Cellular" versions of
the histograms (then you don't need to  have entries for the .Cellular version
of the histograms):

  <fieldtrial name="PrecacheCellular" separator=".">
    <group name="Cellular" label="covers only data downloaded over cellular
networks"/>
    <affected-histogram name="Precache.DailyDownloadedNonPrecacheKB"/>
    <affected-histogram name="Precache.DailySavedKB"/>
    <affected-histogram name="Precache.DailySavingsPercentage"/>
  </fieldtrial>

(The fieldtrial tag name is a misnomer, since field trials no longer use this
mechanism, but it lets you created suffixed versions of histograms.)

[sclittle, 2013/11/19 04:03:41]

Done.

+  <summary>
+    The daily number of kilobytes that were downloaded over cellular networks
+    for HTTP/HTTPS fetches that were not motivated by precaching.
+  </summary>
+</histogram>
+
+<histogram name="Precache.DailyDownloadedPrecacheMotivatedKB" units="KB">
+  <summary>
+    The daily number of kilobytes that were downloaded because of precaching.
+  </summary>
+</histogram>
+
+<histogram name="Precache.DailySavedKB" units="KB">
+  <summary>
+    The daily number of kilobytes during user browsing that were served from the
+    cache, but would have been downloaded over a network if precaching was
+    disabled.
+  </summary>
+</histogram>
+
+<histogram name="Precache.DailySavedKB.Cellular" units="KB">
+  <summary>
+    The daily number of kilobytes during user browsing that were served from the
+    cache, but would have been downloaded over a cellular network if precaching
+    was disabled.
+  </summary>
+</histogram>
+
+<histogram name="Precache.DailySavingsPercentage" units="%">
+  <summary>
+    The daily percentage of user browsing bandwidth on any network that was
+    saved because of precaching.
+  </summary>
+</histogram>
+
+<histogram name="Precache.DailySavingsPercentage.Cellular" units="%">
+  <summary>
+    The daily percentage of user browsing bandwidth on cellular networks that
+    was saved because of precaching.
+  </summary>
+</histogram>
+
 <histogram name="Prerender.Events" enum="PrerenderHoverEvent">
   <obsolete>
     deprecated May 10 2012