Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h

Issue 2704673003: Check same-thread Persistent<> read access. (Closed)
Patch Set: final comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h
index a987ff3d6f26ac1f7d30254c058d8bd0e2462079..801a4450869bec05b5f29a7a420f6cb38e2f0a6c 100644
--- a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h
@@ -58,7 +58,8 @@ class MediaStreamAudioDestinationHandler final
// This Persistent doesn't make a reference cycle.
Persistent<MediaStream> m_stream;
- Persistent<MediaStreamSource> m_source;
+ // Accessed by main thread and during audio thread processing.
+ CrossThreadPersistent<MediaStreamSource> m_source;
// This synchronizes dynamic changes to the channel count with
// process() to manage the mix bus.

Powered by Google App Engine
This is Rietveld 408576698