Issue 270463003: Don't use return value of compositeAndReadbackAsync so it can be void.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270463003: Don't use return value of compositeAndReadbackAsync so it can be void. (Closed)

Created:
6 years, 7 months ago by danakj

Modified:
6 years, 7 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, enne (OOO), piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't use return value of compositeAndReadbackAsync so it can be void. This pulls out the piece from https://codereview.chromium.org/266243002/ to stop using the return value of compositeAndReadbackAsync in order to remove the return value and replace it with an ASSERT in this: https://codereview.chromium.org/263253002/. R=abarth BUG=251960 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268958

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	content/shell/renderer/test_runner/WebTestProxy.cpp	View	1	1 chunk	+10 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/270463003/40001

6 years, 7 months ago (2014-05-07 18:31:19 UTC) #4

Message was sent while issue was closed.

Change committed as 268958