Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 27046003: Handle content_shell failing to start on android as device going offline. (Closed)

Created:
7 years, 2 months ago by Dirk Pranke
Modified:
7 years, 2 months ago
Reviewers:
Peter Beverloo, ojan
CC:
blink-reviews
Visibility:
Public.

Description

Handle content_shell failing to start on android as device going offline. This should then take advantage of the new "fault-tolerance" mode in run-webkit-tests and redirect all the tests queued for that device to another one. Note that this behavior isn't ideal because it's possible content_shell could just be broken (and it's not a device-level issue at all), but this is worth giving a shot. TBR=ojan@chromium.org, peter@chromium.org BUG=305040, 306313 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159466

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py View 2 chunks +11 lines, -3 lines 1 comment Download
M Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/driver.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
TBR'ing since the bot is current hosed because of a device issue, so let's see ...
7 years, 2 months ago (2013-10-11 18:13:24 UTC) #1
Dirk Pranke
Committed patchset #1 manually as r159466 (presubmit successful).
7 years, 2 months ago (2013-10-11 18:13:48 UTC) #2
Dirk Pranke
Also, if this actually turns out to be useful enough to keep, I'll come back ...
7 years, 2 months ago (2013-10-11 18:19:12 UTC) #3
Peter Beverloo
7 years, 2 months ago (2013-10-15 16:40:07 UTC) #4
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/27046003/diff/1/Tools/Scripts/webkitpy/layout...
File Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
(right):

https://codereview.chromium.org/27046003/diff/1/Tools/Scripts/webkitpy/layout...
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:245: if
device_offline:
nit: throw a DeviceOffline exception to avoid code duplication with lines
249-253?

Powered by Google App Engine
This is Rietveld 408576698