Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 2704573004: Adjusted spec to outlaw built-in identifiers in type annotations. (Closed)

Created:
3 years, 10 months ago by eernst
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjusted spec to outlaw built-in identifiers in type annotations. Addresses issue https://github.com/dart-lang/sdk/issues/28817. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/5de9108c16f1eeddf4b8a3a47c60eecb55758ee2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M docs/language/dartLangSpec.tex View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 8 (3 generated)
eernst
Adjusted wording to outlaw built-in identifiers in some cases where they clearly do not make ...
3 years, 10 months ago (2017-02-17 15:40:17 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/2704573004/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2704573004/diff/1/docs/language/dartLangSpec.tex#newcode5407 docs/language/dartLangSpec.tex:5407: It is a compile-time error to use a built-in ...
3 years, 10 months ago (2017-02-19 11:43:53 UTC) #4
Lasse Reichstein Nielsen
lgtm
3 years, 10 months ago (2017-02-19 11:44:00 UTC) #5
eernst
Agreed. https://codereview.chromium.org/2704573004/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2704573004/diff/1/docs/language/dartLangSpec.tex#newcode5407 docs/language/dartLangSpec.tex:5407: It is a compile-time error to use a ...
3 years, 10 months ago (2017-02-20 08:25:12 UTC) #6
eernst
3 years, 10 months ago (2017-02-20 08:28:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5de9108c16f1eeddf4b8a3a47c60eecb55758ee2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698