telemetry/telemetry/page/cache_temperature.py - Issue 2704493002: [Telemetry] Fix bug in markers for cache temperature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/cache_temperature.py

Issue 2704493002: [Telemetry] Fix bug in markers for cache temperature (Closed)

Patch Set: add tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/cache_temperature.py

diff --git a/telemetry/telemetry/page/cache_temperature.py b/telemetry/telemetry/page/cache_temperature.py

index d4782793958f8e0c1a3b19703c9f9b106f8ed9b4..442d6949033f67244cd6c651c2099fb74e24d110 100644

--- a/telemetry/telemetry/page/cache_temperature.py

+++ b/telemetry/telemetry/page/cache_temperature.py

@@ -42,7 +42,7 @@ class MarkTelemetryInternal(object):

if exception_type:

return True

- marker = 'telemetry.internal.%s.start' % self.identifier

+ marker = 'telemetry.internal.%s.end' % self.identifier

self.browser.tabs[0].ExecuteJavaScript2(

"console.time({{ marker }});", marker=marker)

self.browser.tabs[0].ExecuteJavaScript2(

« no previous file with comments | « no previous file | telemetry/telemetry/page/cache_temperature_unittest.py » ('j') | no next file with comments »