Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2704463003: Revert of Consider any testharness result with >= 1 PASS and no FAIL to be passing. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
Manuel Rego, jeffcarp
CC:
blink-reviews, chromium-reviews, mlamouri (slow - plz ping)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Consider any testharness result with >= 1 PASS and no FAIL to be passing. (patchset #4 id:60001 of https://codereview.chromium.org/2668973002/ ) Reason for revert: This CL had the effect of causing hundreds of existing baselines to fail presubmit -- see http://crbug.com/687492 (I think I'd still like to reland this later, but after discussion Original issue's description: > Consider any testharness result with >= 1 PASS and no FAIL to be passing. > > This changes the rule about testharness test results to make > it less conservative and simpler - so that newlines and text > in the output are OK, and the test is considered passing as > long as there's at least one PASS and no FAIL. > > BUG=687492 > > Review-Url: https://codereview.chromium.org/2668973002 > Cr-Commit-Position: refs/heads/master@{#448045} > Committed: https://chromium.googlesource.com/chromium/src/+/a8bd98b223f058a993bbfebbbfd5225544907fda TBR=jeffcarp@chromium.org,rego@igalia.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=687492

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+820 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/webaudio/decodeAudioData/decode-audio-data-basic-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element-expected.txt View 1 2 1 chunk +252 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/webaudio/decodeAudioData/decode-audio-data-basic-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element-expected.txt View 1 2 1 chunk +252 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element-expected.txt View 1 2 1 chunk +252 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/webaudio/decodeAudioData/decode-audio-data-basic-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py View 1 1 chunk +28 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py View 1 4 chunks +10 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
qyearsley
Created Revert of Consider any testharness result with >= 1 PASS and no FAIL to ...
3 years, 10 months ago (2017-02-16 16:42:53 UTC) #1
jeffcarp
lgtm
3 years, 10 months ago (2017-02-16 19:54:39 UTC) #6
Manuel Rego
LGTM too.
3 years, 10 months ago (2017-02-17 09:48:57 UTC) #11
qyearsley
On 2017/02/17 at 09:48:57, rego wrote: > LGTM too. Alright -- There are some tests ...
3 years, 10 months ago (2017-02-17 17:53:08 UTC) #14
qyearsley
3 years, 10 months ago (2017-02-23 19:07:41 UTC) #17
Abandoning the revert (see http://crbug.com/687492)

Powered by Google App Engine
This is Rietveld 408576698