Revert of Consider any testharness result with >= 1 PASS and no FAIL to be passing. (patchset #4 id:60001 of https://codereview.chromium.org/2668973002/ )
Reason for revert:
This CL had the effect of causing hundreds of existing baselines to fail presubmit -- see http://crbug.com/687492 (I think I'd still like to reland this later, but after discussion
Original issue's description:
> Consider any testharness result with >= 1 PASS and no FAIL to be passing.
>
> This changes the rule about testharness test results to make
> it less conservative and simpler - so that newlines and text
> in the output are OK, and the test is considered passing as
> long as there's at least one PASS and no FAIL.
>
> BUG=687492
>
> Review-Url: https://codereview.chromium.org/2668973002
> Cr-Commit-Position: refs/heads/master@{#448045}
> Committed: https://chromium.googlesource.com/chromium/src/+/a8bd98b223f058a993bbfebbbfd5225544907fdaTBR=jeffcarp@chromium.org,rego@igalia.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687492
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/384167)
3 years, 10 months ago
(2017-02-16 17:54:45 UTC)
#5
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/390199)
3 years, 10 months ago
(2017-02-16 23:51:52 UTC)
#10
On 2017/02/17 at 09:48:57, rego wrote: > LGTM too. Alright -- There are some tests ...
3 years, 10 months ago
(2017-02-17 17:53:08 UTC)
#14
On 2017/02/17 at 09:48:57, rego wrote:
> LGTM too.
Alright -- There are some tests that have all-PASS results but with console
messages which have to be rebaselined; will commit after rebaselining.
Note that after this, I think I'd like to reland the original CL, but before I
do that I should
(1) discuss on blink-dev
(2) include deletion of all the unnecessary all-PASS -expected.txt files in
that CL
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago
(2017-02-17 18:20:21 UTC)
#15
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/390738)
3 years, 10 months ago
(2017-02-17 18:20:22 UTC)
#16
Issue 2704463003: Revert of Consider any testharness result with >= 1 PASS and no FAIL to be passing.
(Closed)
Created 3 years, 10 months ago by qyearsley
Modified 3 years, 10 months ago
Reviewers: jeffcarp, Manuel Rego
Base URL:
Comments: 0