Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 27044002: Clean up SkTypes.h. (Closed)

Created:
7 years, 2 months ago by bungeman-skia
Modified:
7 years, 2 months ago
Reviewers:
djsollen, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Clean up SkTypes.h. This change removes sk_stdint.h since it is only needed for vs2008 and earlier. This change removes SK_MMAP_SUPPORT define since it is no longer used. This change removes the stdio.h include from SkTypes.h since on many systems this is a very large header, few Skia files actually use it, it is available everywhere standard, and SkDebugf should be used instead. After this change there is no need for external users to put Skia's include/config into their own list of includes, saving the headache of having two header files of the same name and sometimes getting the wrong one depending on include order. R=bsalomon@google.com, djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=11738

Patch Set 1 #

Patch Set 2 : Correct list of files. #

Total comments: 2

Patch Set 3 : SkString, not String. #

Patch Set 4 : For patch -p1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -70 lines) Patch
M bench/SkBenchLogger.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D include/config/sk_stdint.h View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
M include/core/SkPreConfig.h View 1 2 3 2 chunks +0 lines, -12 lines 0 comments Download
M include/core/SkStream.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkTypes.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
M samplecode/SampleDegenerateTwoPtRadials.cpp View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M samplecode/SampleEmptyPath.cpp View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M samplecode/SamplePath.cpp View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/ClipCubicTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/FontNamesTest.cpp View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M tests/MathTest.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M tests/Matrix44Test.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/MatrixTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsQuadReduceOrderTest.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/StringTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/WArrayTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
bungeman-skia
7 years, 2 months ago (2013-10-11 16:56:47 UTC) #1
djsollen
WooHoo...I'm a bit fan of this change. If you make the one change I'll be ...
7 years, 2 months ago (2013-10-11 17:08:14 UTC) #2
bungeman-skia
https://codereview.chromium.org/27044002/diff/14001/samplecode/SampleDegenerateTwoPtRadials.cpp File samplecode/SampleDegenerateTwoPtRadials.cpp (right): https://codereview.chromium.org/27044002/diff/14001/samplecode/SampleDegenerateTwoPtRadials.cpp#newcode13 samplecode/SampleDegenerateTwoPtRadials.cpp:13: #include "String.h" On 2013/10/11 17:08:15, djsollen wrote: > do ...
7 years, 2 months ago (2013-10-11 17:25:34 UTC) #3
djsollen
lgtm, but as sheriff I would prefer you run this through most of the builder ...
7 years, 2 months ago (2013-10-11 17:27:24 UTC) #4
bsalomon
On 2013/10/11 17:27:24, djsollen wrote: > lgtm, but as sheriff I would prefer you run ...
7 years, 2 months ago (2013-10-11 18:07:06 UTC) #5
bungeman-skia
Committed patchset #4 manually as r11738 (presubmit successful).
7 years, 2 months ago (2013-10-11 18:50:53 UTC) #6
bungeman-skia
On 2013/10/11 18:50:53, bungeman1 wrote: > Committed patchset #4 manually as r11738 (presubmit successful). Somewhat ...
7 years, 2 months ago (2013-10-11 20:39:48 UTC) #7
bungeman-skia
7 years, 2 months ago (2013-10-11 20:41:12 UTC) #8
Message was sent while issue was closed.
On 2013/10/11 20:39:48, bungeman1 wrote:
> On 2013/10/11 18:50:53, bungeman1 wrote:
> > Committed patchset #4 manually as r11738 (presubmit successful).
> 
> Somewhat distressingly, even though all of the trybot builds were green, this
> requires follow on commits r11739, r11740, r11741, r11743, r11744, and r11745.

Actually, r11739 isn't technically needed for this.

Powered by Google App Engine
This is Rietveld 408576698