Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2704383006: arc: Handle metrics for Auth operations. (Closed)
Patch Set: update histogram.xml to match change Arc.Auth to ArcAuth Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4ae0fc1a0f6d2344445d30cee432445739e38446..16ef21e7d927ac46651a95bcd5b98989bf24cf1a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -1597,6 +1597,33 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="ArcAuth.CheckinAttempts" units="attempts">
+ <owner>elijahtaylor@google.com</owner>
Ilya Sherman 2017/02/23 21:23:35 Can you use an @chromium.org address here? Also,
khmel 2017/02/23 21:57:45 I changed to @chromium.org (however in many other
+ <summary>
+ Number of attempts did while waiting for checkin task completed before GMS
Ilya Sherman 2017/02/23 21:23:34 nit: s/did/done
Ilya Sherman 2017/02/23 21:23:34 nit: s/checkin task completed/the check-in task to
khmel 2017/02/23 21:57:45 Done.
khmel 2017/02/23 21:57:45 Done.
+ sign-in. 0 means that device was already checked-in prior to GMS sign-in.
Ilya Sherman 2017/02/23 21:23:35 Please document when this is recorded -- on succes
khmel 2017/02/23 21:57:45 Done.
+ </summary>
+</histogram>
+
+<histogram name="ArcAuth.CheckinTime" units="ms">
+ <owner>elijahtaylor@google.com</owner>
+ <summary>
+ Elapsed time waiting for checkin task completed before GMS sign-in.
Ilya Sherman 2017/02/23 21:23:35 Same grammatical tweak suggestions as above. Also
khmel 2017/02/23 21:57:45 I removed mentioning GMS sign-in. It is actually n
+ </summary>
+</histogram>
+
+<histogram name="ArcAuth.NetworkWaitTime" units="ms">
+ <owner>elijahtaylor@google.com</owner>
+ <summary>
+ Elapsed time waiting for network connection before GMS sign-in.
+ </summary>
+</histogram>
+
+<histogram name="ArcAuth.SignInTime" units="ms">
+ <owner>elijahtaylor@google.com</owner>
+ <summary>Elapsed time waiting for GMS sign-in completed.</summary>
+</histogram>
+
<histogram name="ArcRuntime.LowMemoryKiller.FreedSize" units="KB">
<obsolete>
Renamed to Arc.LowMemoryKiller.FreedSize on 2016/03/24.
« chrome/browser/chromeos/arc/arc_optin_uma.cc ('K') | « components/arc/common/auth.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698