arc: Handle metrics for Auth operations.

chrome/browser/chromeos/arc/arc_optin_uma.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_optin_uma.h"
 
 #include <string>
 
 #include "base/metrics/histogram_macros.h"
 
 namespace arc {
 
+namespace {
+
+constexpr char kArcAuthHistogramPrefix[] = "Arc.Auth.";
+
+std::string GetAuthHistogramName(const std::string& key) {
+  return kArcAuthHistogramPrefix + key;

[dcheng, 2017/02/23 19:50:19]

Just add the Arc.Auth. prefix to the UMAs, it'll be easier to grep that way.

[khmel, 2017/02/23 20:06:35]

Done.

+}
+
+}  // namespace
+
 void UpdateOptInActionUMA(OptInActionType type) {
   UMA_HISTOGRAM_ENUMERATION("Arc.OptInAction", static_cast<int>(type),
                             static_cast<int>(OptInActionType::SIZE));
 }
 
 void UpdateOptInCancelUMA(OptInCancelReason reason) {
   UMA_HISTOGRAM_ENUMERATION("Arc.OptInCancel", static_cast<int>(reason),
                             static_cast<int>(OptInCancelReason::SIZE));
 }
 
@@ skipping 21 matching lines @@
   // The macro UMA_HISTOGRAM_CUSTOM_TIMES expects a constant string, but since
   // this measurement happens very infrequently, we do not need to use a macro
   // here.
   base::Histogram::FactoryTimeGet(
       histogram_name, base::TimeDelta::FromSeconds(1),
       base::TimeDelta::FromMinutes(6), 50,
       base::HistogramBase::kUmaTargetedHistogramFlag)
       ->AddTime(elapsed_time);
 }
 
+void UpdateAuthTiming(const std::string& key,

[dcheng, 2017/02/23 19:50:19]

And then pass this as const char* to save some temporary string constructions

[khmel, 2017/02/23 20:06:35]

Done.

+                      const base::TimeDelta& elapsed_time) {

[dcheng, 2017/02/23 19:50:19]

Nit: pass by value

[khmel, 2017/02/23 20:06:36]

Done.

+  base::Histogram::FactoryTimeGet(
+      GetAuthHistogramName(key), base::TimeDelta::FromSeconds(1) /* minimum */,
+      base::TimeDelta::FromMinutes(3) /* maximum */, 50 /* bucket_count */,
+      base::HistogramBase::kUmaTargetedHistogramFlag)
+      ->AddTime(elapsed_time);
+}
+
+void UpdateAuthAttempts(const std::string& key, int32_t value) {
+  UMA_HISTOGRAM_CUSTOM_COUNTS(GetAuthHistogramName(key), value, 0 /* minimum */,
+                              5 /* maximum */, 6 /* bucket_count */);
+}
+
 void UpdateSilentAuthCodeUMA(OptInSilentAuthCode state) {
   UMA_HISTOGRAM_ENUMERATION("Arc.OptInSilentAuthCode", static_cast<int>(state),
                             static_cast<int>(OptInSilentAuthCode::SIZE));
 }
 
 std::ostream& operator<<(std::ostream& os, const ProvisioningResult& result) {
 #define MAP_PROVISIONING_RESULT(name) \
   case ProvisioningResult::name:      \
     return os << #name
 
@@ skipping 22 matching lines @@
 
 #undef MAP_PROVISIONING_RESULT
 
   // Some compilers report an error even if all values of an enum-class are
   // covered exhaustively in a switch statement.
   NOTREACHED() << "Invalid value " << static_cast<int>(result);
   return os;
 }
 
 }  // namespace arc