Linux/Windows: Crash in profile switcher menu with account consistency enabled

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/macros.h"
 #include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 177 matching lines @@
 class BackgroundColorHoverButton : public views::LabelButton {
  public:
   BackgroundColorHoverButton(ProfileChooserView* profile_chooser_view,
                              const base::string16& text)
       : views::LabelButton(profile_chooser_view, text),
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
         profile_chooser_view_(profile_chooser_view),
 #endif
         title_(nullptr),
         subtitle_(nullptr) {
+    DCHECK(profile_chooser_view);
     SetImageLabelSpacing(switches::IsMaterialDesignUserMenu()
                              ? (kMaterialMenuEdgeMargin - 2)
                              : views::kItemLabelSpacing);
     const int button_margin = switches::IsMaterialDesignUserMenu()
                                   ? kMaterialMenuEdgeMargin
                                   : views::kButtonHEdgeMarginNew;
     SetBorder(views::CreateEmptyBorder(0, button_margin, 0, button_margin));
     SetFocusForPlatform();
 
     if (switches::IsMaterialDesignUserMenu()) {
@@ skipping 1901 matching lines @@
   int warning_button_width = 0;
   if (reauth_required) {
     const int kIconSize = 18;
     warning_default_image = gfx::CreateVectorIcon(
         gfx::VectorIconId::WARNING, kIconSize, gfx::kChromeIconGrey);
     warning_button_width = kIconSize + views::kRelatedButtonHSpacing;
   }
   int available_width = width - 2 * views::kButtonHEdgeMarginNew -
                         kDeleteButtonWidth - warning_button_width;
   views::LabelButton* email_button = new BackgroundColorHoverButton(
-      reauth_required ? this : NULL,

[Peter Kasting, 2017/02/23 01:35:02]

Why were we trying to pass null before?  Usually that means we're trying to
toggle some behavior the constructed object will key off.

[jlebel, 2017/02/23 18:02:57]

You are right, I missed a feature related to this button. The button should be
disable if reauth is not required.

[Peter Kasting, 2017/02/24 00:51:19]

Will disabling the button cause it to draw differently (different colors)?

-      base::UTF8ToUTF16(email),
-      warning_default_image);
+      this, base::UTF8ToUTF16(email), warning_default_image);
   email_button->SetElideBehavior(gfx::ELIDE_EMAIL);
   email_button->SetMinSize(gfx::Size(0, kButtonHeight));
   email_button->SetMaxSize(gfx::Size(available_width, kButtonHeight));
   layout->StartRow(1, 0);
   layout->AddView(email_button);
 
   if (reauth_required)
     reauth_account_button_map_[email_button] = account_id;
 
   // Delete button.
@@ skipping 248 matching lines @@
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognito_available && !browser_->profile()->IsGuestSession();
 }
 
 void ProfileChooserView::PostActionPerformed(
     ProfileMetrics::ProfileDesktopMenu action_performed) {
   ProfileMetrics::LogProfileDesktopMenu(action_performed, gaia_service_type_);
   gaia_service_type_ = signin::GAIA_SERVICE_TYPE_NONE;
 }