Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 27043010: Add support for Token::NE and Token::NE_STRICT to TokenToCondition. (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer
Modified:
7 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Add support for Token::NE and Token::NE_STRICT to TokenToCondition. This is required to be able to use these tokens with HCompareNumericAndBranch. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Sven, Next baby step towards Hydrogen StringAddStub. PTAL -- Benedikt
7 years, 2 months ago (2013-10-16 11:31:04 UTC) #1
Sven Panne
lgtm
7 years, 2 months ago (2013-10-16 12:18:52 UTC) #2
Benedikt Meurer
7 years, 2 months ago (2013-10-16 12:20:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698