bluetooth: Add connected icon to Bluetooth Chooser on Android

chrome/android/java/res/layout/item_chooser_dialog_row.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

[Ted C, 2017/03/03 00:56:19]

Any idea why this is a RelativeLayout?  I think a LinearLayout with horizontal
is easier to read than a RelativeLayout.

[ortuno, 2017/03/03 22:08:22]

There are a couple of row layouts the ItemChooser will have to support:

1. Single line layout (This is the one we currently have).
2. Single line layout with icon.
3. Two line layout.
4. Two line layout with icon.


ianwen suggested:

<RelativeLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:background="@android:color/darker_gray">

    <ImageView
        android:id="@+id/icon"
        android:layout_width="wrap_content"
        android:layout_height="24dp"
        android:layout_alignParentStart="true"
        android:layout_centerInParent="true"
        android:layout_margin="16dp"
        android:src="@mipmap/ic_launcher"/>

    <TextView
        android:id="@+id/title"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_toEndOf="@id/icon"
        android:layout_margin="5dp"
        android:text="Title"/>

    <TextView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_below="@id/title"
        android:layout_toEndOf="@id/icon"
        android:layout_margin="5dp"
        android:text="Details"/>
</RelativeLayout>

So we changed to RelativeLayout. Happy to change if you think LinearLayout is a
better layout.

[Ted C, 2017/03/04 00:08:46]

When are we going to support the other types?  In general, I don't like
designing for a future that might never come to pass.

[ortuno, 2017/03/08 06:57:37]

I'm currently working on adding all those layouts :) First this patch to add the
icon, then a follow up to add the second line of text.

                 android:layout_width="match_parent"
                 android:layout_height="48dp"
                 android:paddingStart="16dp"
                 android:paddingEnd="16dp"
                 android:background="@drawable/item_chooser_row_background">
+    <!-- contentDescription is added at runtime. -->
+    <ImageView
+        android:id="@+id/icon"
+        android:contentDescription="@null"
+        android:layout_width="24dp"
+        android:layout_height="24dp"
+        android:layout_centerVertical="true"
+        android:layout_marginEnd="32dp"/>
     <TextView
         android:id="@+id/description"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
+        android:layout_centerVertical="true"
+        android:layout_toEndOf="@id/icon"
         android:ellipsize="end"
         android:maxLines="1"
-        android:textColor="@color/item_chooser_row_text_color"
-        android:layout_centerVertical="true"/>
+        android:textSize="16sp"
+        android:textColor="@color/item_chooser_row_text_color"/>
 </RelativeLayout>