Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2704163002: Add handleNoVariableInitializer event. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Add handleNoVariableInitializer event. BUG=https://github.com/dart-lang/sdk/issues/28833. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/14511ee4f1476ec51c541dba7c96f8837426e383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 10 months ago (2017-02-20 09:14:59 UTC) #2
karlklose
LGTM
3 years, 10 months ago (2017-02-20 09:27:38 UTC) #3
ahe
Committed patchset #1 (id:1) manually as 14511ee4f1476ec51c541dba7c96f8837426e383 (presubmit successful).
3 years, 10 months ago (2017-02-20 10:01:57 UTC) #5
Paul Berry
3 years, 10 months ago (2017-02-20 14:29:29 UTC) #6
Message was sent while issue was closed.
lgtm, thanks!  I'll follow up with a clean-up to AstBuilder to make use of this
information.

Powered by Google App Engine
This is Rietveld 408576698