Implement super operators.

Implement super operators.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d9831ae212bc9dba7a2a3e759367adbfbd4e0e6

[ahe, 2017-02-20 12:50:28]

ahe@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-02-20 13:10:41]

LGTM

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1451: var receiver = pop();
Keep the type annotation?

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/test/fasta/su...
File pkg/front_end/test/fasta/super_rasta_copy.dart (right):

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/test/fasta/su...
pkg/front_end/test/fasta/super_rasta_copy.dart:34: set i(x) {}}
Break '}' to next line.

[ahe, 2017-02-20 13:18:42]

Thank you, Karl!

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1451: var receiver = pop();
On 2017/02/20 13:10:41, karlklose wrote:
> Keep the type annotation?

The annotation doesn't work anymore because Accessors aren't Expressions.

The idea is that there are Expression or Accessor on the stack, and you normally
use popForValue() to automatically convert an Accessor to an expression.
However, ThisAccessor with isSuper true can't be converted to an expression.

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/test/fasta/su...
File pkg/front_end/test/fasta/super_rasta_copy.dart (right):

https://codereview.chromium.org/2704143003/diff/1/pkg/front_end/test/fasta/su...
pkg/front_end/test/fasta/super_rasta_copy.dart:34: set i(x) {}}
On 2017/02/20 13:10:41, karlklose wrote:
> Break '}' to next line.

This is a copy of rasta/super.dart, and it seems to be unintentional. I'll
create a separate CL to fix both.

[ahe, 2017-02-20 13:27:51]

Description was changed from

==========
Implement super operators.
==========

to

==========
Implement super operators.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2d9831ae212bc9dba7a2a3e759367adbfbd4e0e6
==========

[ahe, 2017-02-20 13:27:52]

Committed patchset #1 (id:1) manually as
2d9831ae212bc9dba7a2a3e759367adbfbd4e0e6 (presubmit successful).