gm/rebaseline_server/static/view.html - Issue 270413002: rebaseline_server JSON: pass category values as values, not keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/static/view.html

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gm/rebaseline_server/static/loader.js ('k') | gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gm/rebaseline_server/static/view.html

diff --git a/gm/rebaseline_server/static/view.html b/gm/rebaseline_server/static/view.html

index bbe1f210f3069bd6d7eaddd34148cf3c23cf2947..b2f3fba4f3d750cb4208be14d77d5bb05cdad4f4 100644

--- a/gm/rebaseline_server/static/view.html

+++ b/gm/rebaseline_server/static/view.html

@@ -68,13 +68,13 @@

<td>

resultType<br>

- <label ng-repeat="(resultType, count) in extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE][constants.KEY__VALUES_AND_COUNTS] track by $index">

+ <label ng-repeat="valueAndCount in extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE][constants.KEY__EXTRACOLUMNHEADERS__VALUES_AND_COUNTS]">

<input type="checkbox"

name="resultTypes"

- value="{{resultType}}"

- ng-checked="!isValueInSet(resultType, hiddenResultTypes)"

- ng-click="toggleValueInSet(resultType, hiddenResultTypes); setUpdatesPending(true)">

- {{resultType}} ({{count}})<br>

+ value="{{valueAndCount[0]}}"

+ ng-checked="!isValueInSet(valueAndCount[0], hiddenResultTypes)"

+ ng-click="toggleValueInSet(valueAndCount[0], hiddenResultTypes); setUpdatesPending(true)">

+ {{valueAndCount[0]}} ({{valueAndCount[1]}})<br>

</label>

all

@@ -100,13 +100,13 @@

</td>

<td>

config<br>

- <label ng-repeat="(config, count) in extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG][constants.KEY__VALUES_AND_COUNTS] track by $index">

+ <label ng-repeat="valueAndCount in extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG][constants.KEY__EXTRACOLUMNHEADERS__VALUES_AND_COUNTS]">

<input type="checkbox"

name="configs"

- value="{{config}}"

- ng-checked="!isValueInSet(config, hiddenConfigs)"

- ng-click="toggleValueInSet(config, hiddenConfigs); setUpdatesPending(true)">

- {{config}} ({{count}})<br>

+ value="{{valueAndCount[0]}}"

+ ng-checked="!isValueInSet(valueAndCount[0], hiddenConfigs)"

+ ng-click="toggleValueInSet(valueAndCount[0], hiddenConfigs); setUpdatesPending(true)">

+ {{valueAndCount[0]}} ({{valueAndCount[1]}})<br>

</label>

all