Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: gm/rebaseline_server/imagepairset_test.py

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/imagepairset_test.py
diff --git a/gm/rebaseline_server/imagepairset_test.py b/gm/rebaseline_server/imagepairset_test.py
index c046ec7c7cf6e5e24587439ada4d0c7599fb7912..37be0fe63719a60e2139fce457fd3acea07e5119 100755
--- a/gm/rebaseline_server/imagepairset_test.py
+++ b/gm/rebaseline_server/imagepairset_test.py
@@ -88,12 +88,11 @@ class ImagePairSetTest(unittest.TestCase):
expected_imageset_dict = {
'extraColumnHeaders': {
'builder': {
+ 'counts': [3],
'headerText': 'builder',
'isFilterable': True,
'isSortable': True,
- 'valuesAndCounts': {
- 'MyBuilder': 3
- },
+ 'values': ['MyBuilder'],
borenet 2014/05/08 12:40:18 My concern with this format is that it's possible
epoger 2014/05/08 15:04:35 JSON doesn't have a concept of tuples, but I could
},
'test': {
'headerText': 'which GM test',

Powered by Google App Engine
This is Rietveld 408576698