Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: gm/rebaseline_server/static/view.html

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/rebaseline_server/static/loader.js ('k') | gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <html ng-app="Loader" ng-controller="Loader.Controller"> 3 <html ng-app="Loader" ng-controller="Loader.Controller">
4 4
5 <head> 5 <head>
6 <title ng-bind="windowTitle"></title> 6 <title ng-bind="windowTitle"></title>
7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script> 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script>
8 <script src="constants.js"></script> 8 <script src="constants.js"></script>
9 <script src="loader.js"></script> 9 <script src="loader.js"></script>
10 <link rel="stylesheet" href="view.css"> 10 <link rel="stylesheet" href="view.css">
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 <th colspan="4"> 61 <th colspan="4">
62 Filters 62 Filters
63 </th> 63 </th>
64 <th> 64 <th>
65 Settings 65 Settings
66 </th> 66 </th>
67 </tr> 67 </tr>
68 <tr valign="top"> 68 <tr valign="top">
69 <td> 69 <td>
70 resultType<br> 70 resultType<br>
71 <label ng-repeat="(resultType, count) in extraColumnHeaders[constants.KE Y__EXTRACOLUMN__RESULT_TYPE][constants.KEY__VALUES_AND_COUNTS] track by $index"> 71 <label ng-repeat="valueAndCount in extraColumnHeaders[constants.KEY__EXT RACOLUMN__RESULT_TYPE][constants.KEY__EXTRACOLUMNHEADERS__VALUES_AND_COUNTS]">
72 <input type="checkbox" 72 <input type="checkbox"
73 name="resultTypes" 73 name="resultTypes"
74 value="{{resultType}}" 74 value="{{valueAndCount[0]}}"
75 ng-checked="!isValueInSet(resultType, hiddenResultTypes)" 75 ng-checked="!isValueInSet(valueAndCount[0], hiddenResultTypes)"
76 ng-click="toggleValueInSet(resultType, hiddenResultTypes); setU pdatesPending(true)"> 76 ng-click="toggleValueInSet(valueAndCount[0], hiddenResultTypes) ; setUpdatesPending(true)">
77 {{resultType}} ({{count}})<br> 77 {{valueAndCount[0]}} ({{valueAndCount[1]}})<br>
78 </label> 78 </label>
79 <button ng-click="hiddenResultTypes = {}; updateResults()"> 79 <button ng-click="hiddenResultTypes = {}; updateResults()">
80 all 80 all
81 </button> 81 </button>
82 <button ng-click="hiddenResultTypes = {}; toggleValuesInSet(allResultTyp es, hiddenResultTypes); updateResults()"> 82 <button ng-click="hiddenResultTypes = {}; toggleValuesInSet(allResultTyp es, hiddenResultTypes); updateResults()">
83 none 83 none
84 </button> 84 </button>
85 <button ng-click="toggleValuesInSet(allResultTypes, hiddenResultTypes); updateResults()"> 85 <button ng-click="toggleValuesInSet(allResultTypes, hiddenResultTypes); updateResults()">
86 toggle 86 toggle
87 </button> 87 </button>
88 </td> 88 </td>
89 <td ng-repeat="category in [constants.KEY__EXTRACOLUMN__BUILDER, constants .KEY__EXTRACOLUMN__TEST]"> 89 <td ng-repeat="category in [constants.KEY__EXTRACOLUMN__BUILDER, constants .KEY__EXTRACOLUMN__TEST]">
90 {{category}} 90 {{category}}
91 <br> 91 <br>
92 <input type="text" 92 <input type="text"
93 ng-model="categoryValueMatch[category]" 93 ng-model="categoryValueMatch[category]"
94 ng-change="setUpdatesPending(true)"/> 94 ng-change="setUpdatesPending(true)"/>
95 <br> 95 <br>
96 <button ng-click="setCategoryValueMatch(category, '')" 96 <button ng-click="setCategoryValueMatch(category, '')"
97 ng-disabled="('' == categoryValueMatch[category])"> 97 ng-disabled="('' == categoryValueMatch[category])">
98 clear (show all) 98 clear (show all)
99 </button> 99 </button>
100 </td> 100 </td>
101 <td> 101 <td>
102 config<br> 102 config<br>
103 <label ng-repeat="(config, count) in extraColumnHeaders[constants.KEY__E XTRACOLUMN__CONFIG][constants.KEY__VALUES_AND_COUNTS] track by $index"> 103 <label ng-repeat="valueAndCount in extraColumnHeaders[constants.KEY__EXT RACOLUMN__CONFIG][constants.KEY__EXTRACOLUMNHEADERS__VALUES_AND_COUNTS]">
104 <input type="checkbox" 104 <input type="checkbox"
105 name="configs" 105 name="configs"
106 value="{{config}}" 106 value="{{valueAndCount[0]}}"
107 ng-checked="!isValueInSet(config, hiddenConfigs)" 107 ng-checked="!isValueInSet(valueAndCount[0], hiddenConfigs)"
108 ng-click="toggleValueInSet(config, hiddenConfigs); setUpdatesPe nding(true)"> 108 ng-click="toggleValueInSet(valueAndCount[0], hiddenConfigs); se tUpdatesPending(true)">
109 {{config}} ({{count}})<br> 109 {{valueAndCount[0]}} ({{valueAndCount[1]}})<br>
110 </label> 110 </label>
111 <button ng-click="hiddenConfigs = {}; updateResults()"> 111 <button ng-click="hiddenConfigs = {}; updateResults()">
112 all 112 all
113 </button> 113 </button>
114 <button ng-click="hiddenConfigs = {}; toggleValuesInSet(allConfigs, hidd enConfigs); updateResults()"> 114 <button ng-click="hiddenConfigs = {}; toggleValuesInSet(allConfigs, hidd enConfigs); updateResults()">
115 none 115 none
116 </button> 116 </button>
117 <button ng-click="toggleValuesInSet(allConfigs, hiddenConfigs); updateRe sults()"> 117 <button ng-click="toggleValuesInSet(allConfigs, hiddenConfigs); updateRe sults()">
118 toggle 118 toggle
119 </button> 119 </button>
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 ng-click="toggleValueInArray(imagePair.index, selectedImagePa irs)"> 419 ng-click="toggleValueInArray(imagePair.index, selectedImagePa irs)">
420 </tr> 420 </tr>
421 </table> <!-- imagePairs --> 421 </table> <!-- imagePairs -->
422 </td></tr></table> <!-- table holding results header + imagePairs table --> 422 </td></tr></table> <!-- table holding results header + imagePairs table -->
423 423
424 </div><!-- main display area of selected tab --> 424 </div><!-- main display area of selected tab -->
425 </div><!-- everything: hide until data is loaded --> 425 </div><!-- everything: hide until data is loaded -->
426 426
427 </body> 427 </body>
428 </html> 428 </html>
OLDNEW
« no previous file with comments | « gm/rebaseline_server/static/loader.js ('k') | gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698