Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: gm/rebaseline_server/static/loader.js

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Loader: 2 * Loader:
3 * Reads GM result reports written out by results.py, and imports 3 * Reads GM result reports written out by results.py, and imports
4 * them into $scope.extraColumnHeaders and $scope.imagePairs . 4 * them into $scope.extraColumnHeaders and $scope.imagePairs .
5 */ 5 */
6 var Loader = angular.module( 6 var Loader = angular.module(
7 'Loader', 7 'Loader',
8 ['ConstantsModule'] 8 ['ConstantsModule']
9 ); 9 );
10 10
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 $scope.selectedImagePairs = []; 141 $scope.selectedImagePairs = [];
142 142
143 // Sets within which the user can toggle individual elements. 143 // Sets within which the user can toggle individual elements.
144 $scope.hiddenResultTypes = {}; 144 $scope.hiddenResultTypes = {};
145 $scope.hiddenResultTypes[ 145 $scope.hiddenResultTypes[
146 constants.KEY__RESULT_TYPE__FAILUREIGNORED] = true; 146 constants.KEY__RESULT_TYPE__FAILUREIGNORED] = true;
147 $scope.hiddenResultTypes[ 147 $scope.hiddenResultTypes[
148 constants.KEY__RESULT_TYPE__NOCOMPARISON] = true; 148 constants.KEY__RESULT_TYPE__NOCOMPARISON] = true;
149 $scope.hiddenResultTypes[ 149 $scope.hiddenResultTypes[
150 constants.KEY__RESULT_TYPE__SUCCEEDED] = true; 150 constants.KEY__RESULT_TYPE__SUCCEEDED] = true;
151 $scope.allResultTypes = Object.keys( 151 $scope.allResultTypes =
152 $scope.extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE] 152 $scope.extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE]
153 [constants.KEY__VALUES_AND_COUNTS]); 153 [constants.KEY__EXTRACOLUMNHEADERS__VALUE S];
154 $scope.hiddenConfigs = {}; 154 $scope.hiddenConfigs = {};
155 $scope.allConfigs = Object.keys( 155 $scope.allConfigs =
156 $scope.extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG] 156 $scope.extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG]
157 [constants.KEY__VALUES_AND_COUNTS]); 157 [constants.KEY__EXTRACOLUMNHEADERS__VALUE S];
158 158
159 // Associative array of partial string matches per category. 159 // Associative array of partial string matches per category.
160 $scope.categoryValueMatch = {}; 160 $scope.categoryValueMatch = {};
161 $scope.categoryValueMatch.builder = ""; 161 $scope.categoryValueMatch.builder = "";
162 $scope.categoryValueMatch.test = ""; 162 $scope.categoryValueMatch.test = "";
163 163
164 // If any defaults were overridden in the URL, get them now. 164 // If any defaults were overridden in the URL, get them now.
165 $scope.queryParameters.load(); 165 $scope.queryParameters.load();
166 166
167 // Any image URLs which are relative should be relative to the JSON 167 // Any image URLs which are relative should be relative to the JSON
(...skipping 635 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 */ 803 */
804 $scope.getImageDiffRelativeUrl = function(imagePair) { 804 $scope.getImageDiffRelativeUrl = function(imagePair) {
805 var before = 805 var before =
806 imagePair[constants.KEY__IMAGE_A_URL] + "-vs-" + 806 imagePair[constants.KEY__IMAGE_A_URL] + "-vs-" +
807 imagePair[constants.KEY__IMAGE_B_URL]; 807 imagePair[constants.KEY__IMAGE_B_URL];
808 return before.replace(/[^\w\-]/g, "_") + ".png"; 808 return before.replace(/[^\w\-]/g, "_") + ".png";
809 } 809 }
810 810
811 } 811 }
812 ); 812 );
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698