Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc

Issue 2704123007: mediaview: Fix ARC file system operation deferring. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc
diff --git a/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc b/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc
index b13ff288099efa2df6610b62d851f0fa833dd9b5..ac320de58e44e6ba77cc6868edc3c376ef6b4fcc 100644
--- a/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc
+++ b/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc
@@ -34,6 +34,8 @@ void GetFileSizeOnUIThread(const GURL& url,
auto* runner =
ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
if (!runner) {
+ LOG(ERROR) << "ArcFileSystemOperationRunner unavailable. "
+ << "File system operations are dropped.";
callback.Run(-1);
hidehiko 2017/02/23 08:36:04 (Not due to this change but) Looks a bug (missing
Shuhei Takahashi 2017/02/23 08:49:30 Great catch! Let's fix it now.
}
runner->GetFileSize(url, callback);
@@ -45,6 +47,8 @@ void OpenFileToReadOnUIThread(const GURL& url,
auto* runner =
ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
if (!runner) {
+ LOG(ERROR) << "ArcFileSystemOperationRunner unavailable. "
+ << "File system operations are dropped.";
callback.Run(mojo::ScopedHandle());
return;
}
@@ -58,6 +62,8 @@ void GetDocumentOnUIThread(const std::string& authority,
auto* runner =
ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
if (!runner) {
+ LOG(ERROR) << "ArcFileSystemOperationRunner unavailable. "
+ << "File system operations are dropped.";
callback.Run(mojom::DocumentPtr());
return;
}
@@ -71,6 +77,8 @@ void GetChildDocumentsOnUIThread(const std::string& authority,
auto* runner =
ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
if (!runner) {
+ LOG(ERROR) << "ArcFileSystemOperationRunner unavailable. "
+ << "File system operations are dropped.";
callback.Run(base::nullopt);
return;
}

Powered by Google App Engine
This is Rietveld 408576698