mediaview: Fix ARC file system operation deferring.

chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_FILEAPI_ARC_FILE_SYSTEM_OPERATION_RUNNER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_FILEAPI_ARC_FILE_SYSTEM_OPERATION_RUNNER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 48 matching lines @@
 
   // Creates an instance suitable for unit tests.
   // This instance will run all operations immediately without deferring by
   // default. Also, deferring can be enabled/disabled by calling
   // SetShouldDefer() from friend classes.
   static std::unique_ptr<ArcFileSystemOperationRunner> CreateForTesting(
       ArcBridgeService* bridge_service);
 
   // The standard constructor. A production instance should be created by
   // this constructor.
-  explicit ArcFileSystemOperationRunner(ArcBridgeService* bridge_service);
+  ArcFileSystemOperationRunner(ArcBridgeService* bridge_service,
+                               const Profile* profile);
   ~ArcFileSystemOperationRunner() override;
 
   // Runs file system operations. See file_system.mojom for documentation.
   void GetFileSize(const GURL& url, const GetFileSizeCallback& callback);
   void OpenFileToRead(const GURL& url, const OpenFileToReadCallback& callback);
   void GetDocument(const std::string& authority,
                    const std::string& document_id,
                    const GetDocumentCallback& callback);
   void GetChildDocuments(const std::string& authority,
                          const std::string& parent_document_id,
                          const GetChildDocumentsCallback& callback);
 
   // ArcSessionManager::Observer overrides:
   void OnArcPlayStoreEnabledChanged(bool enabled) override;
 
   // InstanceHolder<mojom::FileSystemInstance>::Observer overrides:
   void OnInstanceReady() override;
   void OnInstanceClosed() override;
 
  private:
   friend class ArcFileSystemOperationRunnerTest;
 
   ArcFileSystemOperationRunner(ArcBridgeService* bridge_service,
+                               const Profile* profile,
                                bool observe_events);
 
   // Called whenever ARC states related to |should_defer_| are changed.
   void OnStateChanged();
 
   // Enables/disables deferring.
   // Friend unit tests can call this function to simulate enabling/disabling
   // deferring.
   void SetShouldDefer(bool should_defer);
 
+  // Profile this runner is associated with.

[hidehiko, 2017/02/23 08:36:04]

Could you note that this can be null for testing?

[Shuhei Takahashi, 2017/02/23 08:49:30]

Done.

+  const Profile* profile_;

[hidehiko, 2017/02/23 08:36:04]

const Profile* const profile_;

In ARC, it is encouraged to make this "const" if it is not changed in the class.
You can find it in ARC style guide.

[Shuhei Takahashi, 2017/02/23 08:49:30]

I agree we want more const :)
Also changed observe_events_.

+
   // Indicates if this instance should register observers to receive events.
   // Usually true, but set to false in unit tests.
   bool observe_events_;
 
   // Set to true if operations should be deferred at this moment.
   // The default is set to false so that operations are not deferred in
   // unit tests.
   bool should_defer_ = false;
 
   // List of deferred operations.
   std::vector<base::Closure> deferred_operations_;
 
   base::WeakPtrFactory<ArcFileSystemOperationRunner> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcFileSystemOperationRunner);
 };
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_FILEAPI_ARC_FILE_SYSTEM_OPERATION_RUNNER_H_