Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js

Issue 2704123006: [Sensors] Clamp given sampling frequency to the minimum supported one (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
diff --git a/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js b/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
index 8971afa35c9053d9326ecae2e11e11ea4fde97e1..1e27c4d01aa2939003206bd00aec32a1a5f3a98d 100644
--- a/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
+++ b/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
@@ -5,11 +5,6 @@
// is called so that the value read in JavaScript are the values expected (the ones
// sent by |updateReading|).
function runGenericSensorTests(sensorType, updateReading, verifyReading) {
- test(() => assert_throws(
- new RangeError(),
- () => new sensorType({frequency: -60})),
- 'Test that negative frequency causes exception from constructor.');
-
sensor_test(sensor => {
sensor.mockSensorProvider.setGetSensorShouldFail(true);
let sensorObject = new sensorType;
@@ -97,6 +92,30 @@ function runGenericSensorTests(sensorType, updateReading, verifyReading) {
}, 'Test that frequency is capped to the maximum supported from frequency.');
sensor_test(sensor => {
+ let minSupportedFrequency = 2;
+ sensor.mockSensorProvider.setMinimumSupportedFrequency(minSupportedFrequency);
+ let sensorObject = new sensorType({frequency: -1});
+ sensorObject.start();
+ let testPromise = sensor.mockSensorProvider.getCreatedSensor()
+ .then(mockSensor => { return mockSensor.addConfigurationCalled(); })
+ .then(mockSensor => {
+ return new Promise((resolve, reject) => {
+ let wrapper = new CallbackWrapper(() => {
+ let configuration = mockSensor.active_sensor_configurations_[0];
+ assert_equals(configuration.frequency, minSupportedFrequency);
+ sensorObject.stop();
+ assert_equals(sensorObject.state, 'idle');
+ resolve(mockSensor);
+ }, reject);
+ sensorObject.onactivate = wrapper.callback;
+ sensorObject.onerror = reject;
+ });
+ })
+ .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
+ return testPromise;
+ }, 'Test that frequency is limited to the minimum supported from frequency.');
+
+ sensor_test(sensor => {
let sensorObject = new sensorType({frequency: 60});
assert_equals(sensorObject.state, 'unconnected');
sensorObject.start();
« no previous file with comments | « device/generic_sensor/sensor_provider_impl.cc ('k') | third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698