Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

Issue 2704123006: [Sensors] Clamp given sampling frequency to the minimum supported one (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorProxy.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/sensor/SensorProxy.h" 5 #include "modules/sensor/SensorProxy.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/frame/LocalFrame.h" 8 #include "core/frame/LocalFrame.h"
9 #include "modules/sensor/SensorProviderProxy.h" 9 #include "modules/sensor/SensorProviderProxy.h"
10 #include "modules/sensor/SensorReadingUpdater.h" 10 #include "modules/sensor/SensorReadingUpdater.h"
11 #include "platform/mojo/MojoHelper.h" 11 #include "platform/mojo/MojoHelper.h"
12 #include "public/platform/Platform.h" 12 #include "public/platform/Platform.h"
13 13
14 using namespace device::mojom::blink; 14 using namespace device::mojom::blink;
15 15
16 namespace blink { 16 namespace blink {
17 17
18 SensorProxy::SensorProxy(SensorType sensorType, 18 SensorProxy::SensorProxy(SensorType sensorType,
19 SensorProviderProxy* provider, 19 SensorProviderProxy* provider,
20 Page* page) 20 Page* page)
21 : PageVisibilityObserver(page), 21 : PageVisibilityObserver(page),
22 m_type(sensorType), 22 m_type(sensorType),
23 m_mode(ReportingMode::CONTINUOUS), 23 m_mode(ReportingMode::CONTINUOUS),
24 m_provider(provider), 24 m_provider(provider),
25 m_clientBinding(this), 25 m_clientBinding(this),
26 m_state(SensorProxy::Uninitialized), 26 m_state(SensorProxy::Uninitialized),
27 m_suspended(false), 27 m_suspended(false) {}
28 m_maximumFrequency(0.0) {}
29 28
30 SensorProxy::~SensorProxy() {} 29 SensorProxy::~SensorProxy() {}
31 30
32 void SensorProxy::dispose() { 31 void SensorProxy::dispose() {
33 m_clientBinding.Close(); 32 m_clientBinding.Close();
34 } 33 }
35 34
36 DEFINE_TRACE(SensorProxy) { 35 DEFINE_TRACE(SensorProxy) {
37 visitor->trace(m_readingUpdater); 36 visitor->trace(m_readingUpdater);
38 visitor->trace(m_observers); 37 visitor->trace(m_observers);
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 203
205 m_sharedBufferHandle = std::move(params->memory); 204 m_sharedBufferHandle = std::move(params->memory);
206 DCHECK(!m_sharedBuffer); 205 DCHECK(!m_sharedBuffer);
207 m_sharedBuffer = 206 m_sharedBuffer =
208 m_sharedBufferHandle->MapAtOffset(kReadBufferSize, params->buffer_offset); 207 m_sharedBufferHandle->MapAtOffset(kReadBufferSize, params->buffer_offset);
209 208
210 if (!m_sharedBuffer) { 209 if (!m_sharedBuffer) {
211 handleSensorError(); 210 handleSensorError();
212 return; 211 return;
213 } 212 }
213 m_frequencyLimits.first = params->minimum_frequency;
214 m_frequencyLimits.second = params->maximum_frequency;
214 215
215 m_maximumFrequency = params->maximum_frequency; 216 DCHECK_GT(m_frequencyLimits.first, 0.0);
216 DCHECK(m_maximumFrequency <= SensorConfiguration::kMaxAllowedFrequency); 217 DCHECK_GE(m_frequencyLimits.second, m_frequencyLimits.first);
218 constexpr double kMaxAllowedFrequency =
219 SensorConfiguration::kMaxAllowedFrequency;
220 DCHECK_GE(kMaxAllowedFrequency, m_frequencyLimits.second);
217 221
218 auto errorCallback = 222 auto errorCallback =
219 WTF::bind(&SensorProxy::handleSensorError, wrapWeakPersistent(this)); 223 WTF::bind(&SensorProxy::handleSensorError, wrapWeakPersistent(this));
220 m_sensor.set_connection_error_handler( 224 m_sensor.set_connection_error_handler(
221 convertToBaseCallback(std::move(errorCallback))); 225 convertToBaseCallback(std::move(errorCallback)));
222 226
223 m_readingUpdater = SensorReadingUpdater::create(this, m_mode); 227 m_readingUpdater = SensorReadingUpdater::create(this, m_mode);
224 228
225 m_state = Initialized; 229 m_state = Initialized;
226 230
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 const device::OneWriterSeqLock& seqlock = buffer->seqlock.value(); 267 const device::OneWriterSeqLock& seqlock = buffer->seqlock.value();
264 auto version = seqlock.ReadBegin(); 268 auto version = seqlock.ReadBegin();
265 auto readingData = buffer->reading; 269 auto readingData = buffer->reading;
266 if (seqlock.ReadRetry(version)) 270 if (seqlock.ReadRetry(version))
267 return false; 271 return false;
268 result = readingData; 272 result = readingData;
269 return true; 273 return true;
270 } 274 }
271 275
272 } // namespace blink 276 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorProxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698