Some improvements to the command-line analyzer's output.

pkg/analyzer_cli/lib/src/error_formatter.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.error_formatter;
 
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
-import 'package:analyzer_cli/src/options.dart';
+import 'package:path/path.dart' as path;
+
+import 'options.dart';
 
 /// Returns the given error's severity.
 ProcessedSeverity _identity(AnalysisError error) =>
     new ProcessedSeverity(error.errorCode.errorSeverity);
 
 String _pluralize(String word, int count) => count == 1 ? word : word + "s";
 
 /// Returns desired severity for the given [error] (or `null` if it's to be
 /// suppressed).
 typedef ProcessedSeverity _SeverityProcessor(AnalysisError error);
@@ skipping 68 matching lines @@
         out.write(" and ");
       }
       out.write(lintCount);
       out.write(' ');
       out.write(_pluralize("lint", lintCount));
       hasContent = true;
     }
     if (hasContent) {
       out.writeln(" found.");
     } else {
-      out.writeln("No issues found");
+      out.writeln("No issues found!");
     }
   }
 }
 
 /// Helper for formatting [AnalysisError]s.
 /// The two format options are a user consumable format and a machine consumable
 /// format.
 class ErrorFormatter {
   static final int _pipeCodeUnit = '|'.codeUnitAt(0);
   static final int _slashCodeUnit = '\\'.codeUnitAt(0);
@@ skipping 35 matching lines @@
       out.write('|');
       out.write(escapePipe(source.fullName));
       out.write('|');
       out.write(location.lineNumber);
       out.write('|');
       out.write(location.columnNumber);
       out.write('|');
       out.write(length);
       out.write('|');
       out.write(escapePipe(error.message));
+      out.writeln();
     } else {
       // Get display name.
       String errorType = severity.displayName;
 
       // Translate INFOs into LINTS and HINTS.
       if (severity == ErrorSeverity.INFO) {
         if (error.errorCode.type == ErrorType.HINT ||
             error.errorCode.type == ErrorType.LINT) {
           errorType = error.errorCode.type.displayName;
         }
       }
 
-      // [warning] 'foo' is not a... (/Users/.../tmp/foo.dart, line 1, col 2)
-      out.write('[$errorType] ${error.message} ');
-      out.write('(${source.fullName}');
-      out.write(', line ${location.lineNumber}, col ${location.columnNumber})');
+      int indent = errorType.length + 3;
+
+      // [warning] 'foo' is not a bar at lib/foo.dart:1:2 (foo_warning).
+      String message = error.message;
+      // Remove any terminating '.' from the end of the message.
+      if (message.endsWith('.')) {
+        message = message.substring(0, message.length - 1);
+      }
+      out.write('[$errorType] $message ');
+      String sourceName;
+      if (source.uriKind == UriKind.DART_URI) {
+        sourceName = source.uri.toString();
+      } else if (source.uriKind == UriKind.PACKAGE_URI) {
+        sourceName = _relative(source.fullName);
+        if (sourceName == source.fullName) {
+          // If we weren't able to shorten the path name, use the package: version.
+          sourceName = source.uri.toString();
+        }
+      } else {
+        sourceName = _relative(source.fullName);
+      }
+      out.write('at $sourceName');
+      out.write(':${location.lineNumber}:${location.columnNumber} ');
+      out.write('(${error.errorCode.name.toLowerCase()}).');
+      out.writeln();
+
+      // If verbose, also print any associated correction.
+      if (options.verbose && error.correction != null) {
+        out.writeln('${' '.padLeft(indent)}${error.correction}');
+      }
     }
-    out.writeln();
   }
 
   void formatErrors(List<AnalysisErrorInfo> errorInfos) {
     stats.unfilteredCount += errorInfos.length;
 
     var errors = new List<AnalysisError>();
     var errorToLine = new Map<AnalysisError, LineInfo>();
     for (AnalysisErrorInfo errorInfo in errorInfos) {
       for (AnalysisError error in errorInfo.errors) {
         if (computeSeverity(error) != null) {
@@ skipping 20 matching lines @@
       // Offset.
       return error1.offset - error2.offset;
     });
     // Format errors.
     for (AnalysisError error in errors) {
       ProcessedSeverity processedSeverity = processSeverity(error);
       ErrorSeverity severity = processedSeverity.severity;
       if (severity == ErrorSeverity.ERROR) {
         stats.errorCount++;
       } else if (severity == ErrorSeverity.WARNING) {
-        /// Only treat a warning as an error if it's not been set by a
-        /// proccesser.
+        // Only treat a warning as an error if it's not been set by a processor.
         if (!processedSeverity.overridden && options.warningsAreFatal) {
           stats.errorCount++;
         } else {
           stats.warnCount++;
         }
       } else if (error.errorCode.type == ErrorType.HINT) {
         stats.hintCount++;
       } else if (error.errorCode.type == ErrorType.LINT) {
         stats.lintCount++;
       }
@@ skipping 12 matching lines @@
     return result.toString();
   }
 }
 
 /// A severity with awareness of whether it was overridden by a processor.
 class ProcessedSeverity {
   ErrorSeverity severity;
   bool overridden;
   ProcessedSeverity(this.severity, [this.overridden = false]);
 }
+
+/// Given an absolute path, return a relative path if the file is contained in
+/// the current directory; return the original path otherwise.
+String _relative(String file) {
+  return file.startsWith(path.current) ? path.relative(file) : file;
+}