Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: google_apis/gcm/engine/gservices_settings.h

Issue 270403006: Adding handling of MCS Endpoints to GServicesSettings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing CR feedback Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/gservices_settings.h
diff --git a/google_apis/gcm/engine/gservices_settings.h b/google_apis/gcm/engine/gservices_settings.h
index 92e0e23bbc9943856b8e0cd7c7e46996c9a0f6b9..7961ca278447a374505b4ccebd5effb21329ebbe 100644
--- a/google_apis/gcm/engine/gservices_settings.h
+++ b/google_apis/gcm/engine/gservices_settings.h
@@ -47,10 +47,9 @@ class GCM_EXPORT GServicesSettings {
GURL checkin_url() const { return checkin_url_; }
- // TODO(fgorski): Consider returning GURL and use it for validation.
- std::string mcs_hostname() const { return mcs_hostname_; }
+ GURL mcs_main_endpoint() const { return mcs_main_endpoint_; }
- int mcs_secure_port() const { return mcs_secure_port_; }
+ GURL mcs_fallback_endpoint() const { return mcs_fallback_endpoint_; }
GURL registration_url() const { return registration_url_; }
@@ -70,11 +69,11 @@ class GCM_EXPORT GServicesSettings {
// URL that should be used for checkins.
GURL checkin_url_;
- // Hostname of the MCS server.
- std::string mcs_hostname_;
+ // Main MCS endpoint.
+ GURL mcs_main_endpoint_;
- // Secure port to connect to on MCS sever.
- int mcs_secure_port_;
+ // Fallback MCS endpoint.
+ GURL mcs_fallback_endpoint_;
// URL that should be used for regisrations and unregistrations.
GURL registration_url_;
« no previous file with comments | « no previous file | google_apis/gcm/engine/gservices_settings.cc » ('j') | google_apis/gcm/engine/gservices_settings.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698