Chromium Code Reviews Chromium Code Reviews
Issue 2704013002:
Media Controls: cache the minimum width in order to reduce incorrect width usage. (Closed)
| Index: third_party/WebKit/LayoutTests/media/controls/buttons-after-reset.html |
| diff --git a/third_party/WebKit/LayoutTests/media/controls/buttons-after-reset.html b/third_party/WebKit/LayoutTests/media/controls/buttons-after-reset.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..a08cd65a9dd8602f9879e7e53a8eabdfcdc1ec15 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/media/controls/buttons-after-reset.html |
| @@ -0,0 +1,26 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<title>Test that resetting the controls after load is a no-op.</title> |
| +<script src="../media-file.js"></script> |
| +<video controls width=400> |
| + <track kind=subtitles src=fake-en-sub.vtt srclang=en label=English> |
| + <track kind=subtitles src=fake-fr-sub.vtt srclang=fr label=French> |
| +</video> |
| +<script> |
| + if (window.testRunner) |
| + testRunner.waitUntilDone(); |
| + |
| + var video = document.querySelector('video'); |
| + video.src = findMediaFile('video', '../content/test'); |
| + video.addEventListener('loadedmetadata', () => { |
|
Zhiqiang Zhang (Slow)
2017/02/18 15:04:37
Can you explain why hide and show the controls and
mlamouri (slow - plz ping)
2017/02/19 10:33:57
Without the fix, when we do hide/show, we end up w
|
| + video.controls = false; |
| + testRunner.layoutAndPaintAsyncThen(() => { |
| + video.controls = true; |
| + |
| + testRunner.layoutAndPaintAsyncThen(() => { |
| + testRunner.notifyDone(); |
| + }); |
| + }); |
| + }); |
| +</script> |
| +</html> |
