Don't sent errors for general files if the file has the same signature.

Don't sent errors for general files if the file has the same signature.

The signature is not in AnalysisResult, not used anywhere outside the
the driver itself yet. Do we want it for consistency with UnitElementResult?
Or make private until someone asks?

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e353acf1c96ec4b0414a9eaede1d9fec7910eb1c

[Brian Wilkerson, 2017-02-18 17:40:03]

lgtm

> The signature is not in AnalysisResult, not used anywhere outside
> the driver itself yet. Do we want it for consistency with
> UnitElementResult? Or make private until someone asks?

I'd keep it private until we find a need for it.

https://codereview.chromium.org/2703983002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2703983002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:707: bool skipIfSameSignature:
false}) {
Document what "skipIfSameSignature" does.

https://codereview.chromium.org/2703983002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1413: null, null, null, null,
null, null, null, null, null, null, null, null);
As I understand it, the effect of this CL is to make it possible to not
resynthesize results if the signature hasn't changed, and I like that. And this
instance is used as a marker to indicate that the results haven't changed,
right? If so, perhaps use a more general name, such as `_SAME_RESULTS` or
`_UNCHANGED`.

[scheglov, 2017-02-18 20:15:45]

https://codereview.chromium.org/2703983002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2703983002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:707: bool skipIfSameSignature:
false}) {
On 2017/02/18 17:40:03, Brian Wilkerson wrote:
> Document what "skipIfSameSignature" does.

Done.

https://codereview.chromium.org/2703983002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1413: null, null, null, null,
null, null, null, null, null, null, null, null);
On 2017/02/18 17:40:03, Brian Wilkerson wrote:
> As I understand it, the effect of this CL is to make it possible to not
> resynthesize results if the signature hasn't changed, and I like that. And
this
> instance is used as a marker to indicate that the results haven't changed,
> right? If so, perhaps use a more general name, such as `_SAME_RESULTS` or
> `_UNCHANGED`.

Done.

[scheglov, 2017-02-18 20:20:48]

Description was changed from

==========
Don't sent errors for general files if the file has the same signature.

The signature is not in AnalysisResult, not used anywhere outside the
the driver itself yet. Do we want it for consistency with UnitElementResult?
Or make private until someone asks?

R=brianwilkerson@google.com
BUG=
==========

to

==========
Don't sent errors for general files if the file has the same signature.

The signature is not in AnalysisResult, not used anywhere outside the
the driver itself yet. Do we want it for consistency with UnitElementResult?
Or make private until someone asks?

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e353acf1c96ec4b0414a9eaede1d9fec7910eb1c
==========

[scheglov, 2017-02-18 20:20:51]

Committed patchset #2 (id:20001) manually as
e353acf1c96ec4b0414a9eaede1d9fec7910eb1c (presubmit successful).