Source/modules/webaudio/AudioContext.cpp - Issue 27039002: Fix crash when the OfflineAudioContext constructor is given 0 as numberOfFrames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioContext.cpp

Issue 27039002: Fix crash when the OfflineAudioContext constructor is given 0 as numberOfFrames (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix nits Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt ('k') | Source/modules/webaudio/OfflineAudioContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioContext.cpp

diff --git a/Source/modules/webaudio/AudioContext.cpp b/Source/modules/webaudio/AudioContext.cpp

index fb7d57ef55602524189f2cbec2740afddcc99c6b..18f3df70c123b647cef8ebce9c03949c378cb840 100644

--- a/Source/modules/webaudio/AudioContext.cpp

+++ b/Source/modules/webaudio/AudioContext.cpp

@@ -154,7 +154,9 @@ AudioContext::AudioContext(Document* document, unsigned numberOfChannels, size_t

// Create a new destination for offline rendering.

m_renderTarget = AudioBuffer::create(numberOfChannels, numberOfFrames, sampleRate);

+ ASSERT(m_renderTarget);

m_destinationNode = OfflineAudioDestinationNode::create(this, m_renderTarget.get());

+ ASSERT(m_destinationNode);

}

void AudioContext::constructCommon()