Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: tools/purify/common.py

Issue 27039: Add diagnostic information to help track down why the Purify layout tests... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/tools/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/purify/common.py
===================================================================
--- tools/purify/common.py (revision 10065)
+++ tools/purify/common.py (working copy)
@@ -83,6 +83,8 @@
# TODO(erikkay): should we buffer stderr and stdout separately?
p = subprocess.Popen(proc, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+ logging.info("started subprocess")
+
# How long to wait (in seconds) before printing progress log messages.
progress_delay = 300
progress_delay_time = time.time() + progress_delay
@@ -111,6 +113,11 @@
did_timeout = time.time() > wait_until
if did_timeout:
+ logging.info("process timed out")
+ else:
+ logging.info("process ended, did not time out")
+
+ if did_timeout:
subprocess.call(["taskkill", "/T", "/F", "/PID", str(p.pid)])
logging.error("KILLED %d" % p.pid)
# Give the process a chance to actually die before continuing
@@ -121,8 +128,10 @@
elif not detach:
for line in p.stdout.readlines():
_print_line(line, False)
+ logging.info("flushing stdout")
p.stdout.flush()
+ logging.info("collecting result code")
result = p.poll()
if result:
logging.error("%s exited with non-zero result code %d" % (proc[0], result))
« no previous file with comments | « no previous file | webkit/tools/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698