Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2703873002: Don't treat LinkedDependency URIs as absolute in resynthesizer.dart for backward compatibility. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't treat LinkedDependency URIs as absolute in resynthesizer.dart for backward compatibility. The incompatibility was introduced in: https://github.com/dart-lang/sdk/commit/f224ebda5c476773aa3bd614b8be8bd566cd1e21 R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/da649c979d94ce0857e304847fe4ec563afd846a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-17 20:43:05 UTC) #1
Paul Berry
lgtm
3 years, 10 months ago (2017-02-17 21:16:59 UTC) #2
scheglov
3 years, 10 months ago (2017-02-17 21:38:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da649c979d94ce0857e304847fe4ec563afd846a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698