Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 270383007: linux_aura: Compile ash into chrome. (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, sadrul, tfarina, ben+aura_chromium.org, dcheng, grt+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

linux_aura: Compile ash into chrome. [This is a reland now that the static initializers should be fixed.] Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 TBR=sky@chromium.org First Review URL: https://codereview.chromium.org/25108005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -357 lines) Patch
M ash/accelerators/magnifier_key_scroller.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/display_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 6 chunks +8 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11_unittest.cc View 3 chunks +27 lines, -24 lines 0 comments Download
M build/common.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/fullscreen_aurax11.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_theme.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 11 chunks +57 lines, -56 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/ash/solid_color_user_wallpaper_delegate.h View 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/browser/ui/ash/solid_color_user_wallpaper_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/ui/ash/user_wallpaper_delegate_win.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/ui/ash/user_wallpaper_delegate_win.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 4 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accelerator_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_service_linux.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc View 2 chunks +65 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/ui/views/theme_image_mapper.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/ui/views/theme_image_mapper_aura_win.cc View 1 chunk +0 lines, -40 lines 0 comments Download
A + chrome/browser/ui/views/theme_image_mapper_chromeos.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/theme_image_mapper_desktop.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 4 chunks +36 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 6 chunks +5 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +13 lines, -10 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Committed patchset #1 manually as r270232 (presubmit successful).
6 years, 7 months ago (2014-05-13 22:42:07 UTC) #1
Matt Giuca
6 years, 7 months ago (2014-05-14 05:00:23 UTC) #2
Message was sent while issue was closed. 
This CL introduces a regression to the normal Linux App Launcher. See:
https://code.google.com/p/chromium/issues/detail?id=373128

Powered by Google App Engine
This is Rietveld 408576698