Issue 27038004: [Ozone] HardwareDisplayController unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27038004: [Ozone] HardwareDisplayController unittests (Closed)

Created:
7 years, 2 months ago by dnicoara

Modified:
7 years, 2 months ago

Reviewers:
rjkroege

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Ozone] HardwareDisplayController unittests See https://codereview.chromium.org/26538005/ for implementation. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228358

Patch Set 2 : Added newlines #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+299 lines, -0 lines)			Patch
	A	ui/gfx/ozone/impl/hardware_display_controller_ozone_unittest.cc	View	1	1 chunk	+299 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rjkroege

lgtm with nits https://codereview.chromium.org/27038004/diff/1/ui/gfx/ozone/impl/hardware_display_controller_ozone_unittest.cc File ui/gfx/ozone/impl/hardware_display_controller_ozone_unittest.cc (right): https://codereview.chromium.org/27038004/diff/1/ui/gfx/ozone/impl/hardware_display_controller_ozone_unittest.cc#newcode43 ui/gfx/ozone/impl/hardware_display_controller_ozone_unittest.cc:43: virtual drmModeCrtc* GetCrtc(uint32_t crtc_id) OVERRIDE { ...

7 years, 2 months ago (2013-10-11 21:14:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/27038004/6001

7 years, 2 months ago (2013-10-11 21:57:40 UTC) #3

Message was sent while issue was closed.

Change committed as 228358

Expand Messages | Collapse Messages

Issue 27038004: [Ozone] HardwareDisplayController unittests (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added newlines #

Messages