Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 270373003: Separate RendererCdmManager from RendererMediaPlayerManager. (Closed)

Created:
6 years, 7 months ago by xhwang
Modified:
6 years, 7 months ago
Reviewers:
damienv1, ddorwin
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Separate RendererCdmManager from RendererMediaPlayerManager. This CL also updates the prefixed EME implementation on Android to use the new RendererCdmManager. In a follow up CL RendererCdmManager will also be used by the unprefixed EME implementation. BUG=338910 TEST=Test page still works.

Patch Set 1 #

Patch Set 2 : CL to review. #

Patch Set 3 : Fix typo. #

Patch Set 4 : Fix compile error on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -245 lines) Patch
M content/browser/media/android/browser_media_player_manager.h View 1 2 4 chunks +26 lines, -7 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 13 chunks +45 lines, -14 lines 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/android/proxy_media_keys.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/android/proxy_media_keys.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
A content/renderer/media/android/renderer_cdm_manager.h View 1 1 chunk +88 lines, -0 lines 0 comments Download
A content/renderer/media/android/renderer_cdm_manager.cc View 1 1 chunk +137 lines, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 5 chunks +0 lines, -45 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 6 chunks +0 lines, -118 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 4 chunks +11 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 18 chunks +40 lines, -35 lines 0 comments Download
M content/renderer/media/crypto/content_decryption_module_factory.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/crypto/content_decryption_module_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
PTAL CLs to follow: 1, Support WD EME using the new RendererCdmManager. 2, Move CDM ...
6 years, 7 months ago (2014-05-08 01:00:45 UTC) #1
xhwang
PS 1 copies RendererMediaPlayerManager.* to RendererCdmPlayerManager.* so that I have a good base to show ...
6 years, 7 months ago (2014-05-08 01:03:24 UTC) #2
xhwang
I think I need to make more changes in this CL. Please hold off reviewing ...
6 years, 7 months ago (2014-05-08 16:44:47 UTC) #3
xhwang
It seems pretty hard to have a cleaner solution than the current one without changing ...
6 years, 7 months ago (2014-05-08 21:37:26 UTC) #4
xhwang
6 years, 7 months ago (2014-05-23 22:10:21 UTC) #5
On 2014/05/08 21:37:26, xhwang wrote:
> It seems pretty hard to have a cleaner solution than the current one without
> changing RendererMediaPlayerManager to use RenderFrameObserver. So I'd like to
> keep this CL as is, and I'll clean them up in the next CL.
> 
> PTAL

This CL is obsolete now. It's replaced by
https://codereview.chromium.org/295103015/

Powered by Google App Engine
This is Rietveld 408576698