Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 2703723002: Add an integration test for execution.setSubscriptions. (Closed)

Created:
3 years, 10 months ago by devoncarew
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an integration test for execution.setSubscriptions. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/7c7c8953451e92be6babd44fd87f1ed541f25e50

Patch Set 1 #

Patch Set 2 : revert expectAsync => expectAsync0 change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M pkg/analysis_server/test/integration/coverage.md View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/coverage_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/execution/set_subscription_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/execution/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
devoncarew
- add an integration test for execution.setSubscriptions (marked as failing) - update the coverage.md format ...
3 years, 10 months ago (2017-02-17 05:30:20 UTC) #2
Brian Wilkerson
I think we need to update the version ranges for the test package in the ...
3 years, 10 months ago (2017-02-17 15:08:46 UTC) #3
devoncarew
> I think we need to update the version ranges for the test package Thanks, ...
3 years, 10 months ago (2017-02-17 15:27:24 UTC) #4
Brian Wilkerson
Still lgtm
3 years, 10 months ago (2017-02-17 15:28:33 UTC) #5
devoncarew
3 years, 10 months ago (2017-02-17 15:41:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c7c8953451e92be6babd44fd87f1ed541f25e50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698