Source/modules/webaudio/AudioContext.h - Issue 27037002: Get rid of custom bindings for AudioContext's constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioContext.h

Issue 27037002: Get rid of custom bindings for AudioContext's constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Throw exception when max number of hardware contexts is reached Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/webaudio/audiocontext-max-contexts.html ('K') | « Source/bindings/v8/custom/V8AudioContextCustom.cpp ('k') | Source/modules/webaudio/AudioContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioContext.h

diff --git a/Source/modules/webaudio/AudioContext.h b/Source/modules/webaudio/AudioContext.h

index 0585225c2b5251b55b5349e4d1e37d108df8e85d..51e0a3863275b01e1e998d599e72054d4616d9d9 100644

--- a/Source/modules/webaudio/AudioContext.h

+++ b/Source/modules/webaudio/AudioContext.h

@@ -77,10 +77,10 @@ class WaveShaperNode;

class AudioContext : public ActiveDOMObject, public ScriptWrappable, public ThreadSafeRefCounted<AudioContext>, public EventTargetWithInlineData {

public:

// Create an AudioContext for rendering to the audio hardware.

- static PassRefPtr<AudioContext> create(Document*);

+ static PassRefPtr<AudioContext> create(Document&, ExceptionState&);

- // Create an AudioContext for offline (non-realtime) rendering.

- static PassRefPtr<AudioContext> createOfflineContext(Document*, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState&);

+ // Deprecated: create an AudioContext for offline (non-realtime) rendering.

+ static PassRefPtr<AudioContext> create(Document&, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState&);

virtual ~AudioContext();