Get rid of custom bindings for AudioContext's constructor

Source/bindings/v8/custom/V8AudioContextCustom.cpp

Index: Source/bindings/v8/custom/V8AudioContextCustom.cpp
diff --git a/Source/bindings/v8/custom/V8AudioContextCustom.cpp b/Source/bindings/v8/custom/V8AudioContextCustom.cpp
deleted file mode 100644
index 86e39712deb80fc574ae12a062f78dcc94e8592b..0000000000000000000000000000000000000000
--- a/Source/bindings/v8/custom/V8AudioContextCustom.cpp
+++ /dev/null
@@ -1,77 +0,0 @@
-/*
- * Copyright (C) 2010, Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1.  Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2.  Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
- * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#if ENABLE(WEB_AUDIO)
-#include "V8AudioContext.h"
-
-#include "V8AudioBuffer.h"
-#include "V8OfflineAudioContext.h"
-#include "bindings/v8/V8Binding.h"
-#include "bindings/v8/custom/V8ArrayBufferCustom.h"
-#include "core/dom/Document.h"
-#include "modules/webaudio/AudioBuffer.h"
-#include "modules/webaudio/AudioContext.h"
-#include "modules/webaudio/OfflineAudioContext.h"
-#include "wtf/ArrayBuffer.h"
-
-namespace WebCore {
-
-void V8AudioContext::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
-{
-    Document* document = currentDocument();
-
-    RefPtr<AudioContext> audioContext;
-
-    if (!args.Length()) {
-        // Constructor for default AudioContext which talks to audio hardware.
-        audioContext = AudioContext::create(document);
-        if (!audioContext.get()) {

[haraken, 2013/10/11 15:39:30]

Just to confirm: This branch won't be generated in the auto-generated code, but
it's ok because the branch cannot be hit. Right?

[Inactive, 2013/10/11 16:07:05]

Actually, you are right. AudioContext::create() can return 0 and we should throw
an exception in this case. I will move the exception throwing to
AudioContext::create().

[Inactive, 2013/10/11 16:22:47]

Fixed. And I added a layout test to cover this scenario.

-            throwError(v8SyntaxError, "audio resources unavailable for AudioContext construction", args.GetIsolate());
-            return;
-        }
-    } else {
-        // Constructor for offline (render-target) AudioContext which renders into an AudioBuffer.
-        // new AudioContext(in unsigned long numberOfChannels, in unsigned long numberOfFrames, in float sampleRate);
-        document->addConsoleMessage(JSMessageSource, WarningMessageLevel,
-            "Deprecated AudioContext constructor: use OfflineAudioContext instead");
-
-        V8OfflineAudioContext::constructorCallback(args);
-        return;
-    }
-
-    if (!audioContext.get()) {

[haraken, 2013/10/11 15:39:30]

Ditto.

[Inactive, 2013/10/11 16:07:05]

Looks like this condition can never be true. It would have returned earlier if
it has been null.

-        throwError(v8SyntaxError, "Error creating AudioContext", args.GetIsolate());
-        return;
-    }
-
-    // Transform the holder into a wrapper object for the audio context.
-    v8::Handle<v8::Object> wrapper = args.Holder();
-    V8DOMWrapper::associateObjectWithWrapper<V8AudioContext>(audioContext.release(), &info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);
-    args.GetReturnValue().Set(wrapper);
-}
-
-} // namespace WebCore
-
-#endif // ENABLE(WEB_AUDIO)